Skip to content

multiarch: register libvirt-s390x-vpn-hcp cluster profile (2/2) - #83138

Open
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:register-libvirt-s390x-vpn-hcp-profile
Open

multiarch: register libvirt-s390x-vpn-hcp cluster profile (2/2)#83138
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:register-libvirt-s390x-vpn-hcp-profile

Conversation

@ibm-adarsh

@ibm-adarsh ibm-adarsh commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Dependency (read first)

Depends on: #83082 (1/2)

Merge order:

  1. Merge multiarch: add libvirt-s390x-vpn-hcp Boskos + secret bootstrap (1/2) #83082 first (Boskos lease move + ci-secret-bootstrap for cluster-secrets-libvirt-s390x-vpn-hcp)
  2. Wait until cluster-secrets-libvirt-s390x-vpn-hcp exists in the ci namespace
  3. Then merge this PR (multiarch: register libvirt-s390x-vpn-hcp cluster profile (2/2) #83138, 2/2)

check-cluster-profiles-config will fail on this PR until #83082 is merged and the secret is synced. That is expected — same split as #82161 + #82162.

Summary

Test plan

Summary by CodeRabbit

Registers the libvirt-s390x-vpn-hcp cluster profile for OpenShift CI infrastructure. The profile references its quota slice and cluster secret.

The required secret must be created and synchronized by PR #83082 before check-cluster-profiles-config can pass.

Register the HCP VPN profile after Boskos leases and secret bootstrap from
the companion PR land and cluster-secrets-libvirt-s390x-vpn-hcp exists in ci.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2026
@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Hi @ibm-adarsh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibm-adarsh
Once this PR has been reviewed and has the lgtm label, please assign psalajova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 7699f118-4a02-444f-9080-ce9c23446e63

📥 Commits

Reviewing files that changed from the base of the PR and between b623641 and 3bc960d.

📒 Files selected for processing (1)
  • ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml

Walkthrough

The cluster profile configuration adds libvirt-s390x-vpn-hcp with its quota-slice lease type, profile name, and secret reference.

Changes

Cluster profile configuration

Layer / File(s) Summary
Add cluster profile configuration
ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml
Adds the libvirt-s390x-vpn-hcp profile with its quota-slice lease type, name, and secret reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: josecastillolema, dustman9000, amisstea

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the registration of the libvirt-s390x-vpn-hcp cluster profile and matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only cluster profile YAML; it adds no It, Describe, Context, or When test titles, so no dynamic test name exists to flag.
Test Structure And Quality ✅ Passed PASS: The pull request changes only cluster-profiles-config.yaml and adds no Ginkgo test code, so the listed test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The commit adds only four cluster-profile YAML lines and no Ginkgo tests or test-like files, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only cluster-profiles-config.yaml with four profile fields; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The commit only adds four cluster-profile metadata fields in YAML; it adds no deployment, operator, controller, replica, affinity, topology, node, taint, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only one YAML configuration file; its four added lines contain profile metadata and no OTE process-level stdout or logging code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only cluster-profiles-config.yaml and adds four profile fields; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The PR adds only four YAML profile references; the patch contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges ✅ Passed The patch only adds four cluster-profile references. It adds no container or Kubernetes privilege settings, host namespaces, SYS_ADMIN capability, root user, or privilege escalation.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only YAML identifiers for a cluster profile, quota slice, and secret reference; it adds no logging code or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from smg247 and stbenjam August 8, 2026 07:05
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 8, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ibm-adarsh: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant