Skip to content

setup assisted-installer version v2.55 - #83184

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-8cfb32c5-ceb9-44c7-b01a-6cc0fd91908d
Open

setup assisted-installer version v2.55#83184
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-8cfb32c5-ceb9-44c7-b01a-6cc0fd91908d

Conversation

@danmanor

@danmanor danmanor commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates the Assisted Installer v2.55 CI configurations for the assisted-installer and assisted-installer-agent repositories.
  • Sets always_run: false and moves change-based pipeline skipping to pipeline_skip_if_only_changed for the affected tests.
  • Removes the test-level skip_if_only_changed settings.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ab4294e8-7e84-4fe0-aca0-c880c0d0cc05

📥 Commits

Reviewing files that changed from the base of the PR and between b136251 and 1456b1f.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The v2.55 Assisted Installer test definitions disable unconditional execution and use pipeline_skip_if_only_changed for change-based pipeline skipping.

Changes

Assisted Installer pipeline configuration

Layer / File(s) Summary
Pipeline skip settings
ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The subsystem-test and e2e-metal-assisted definitions set always_run: false. Their change filters now use pipeline_skip_if_only_changed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup, which matches the primary changes in the test configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes four YAML CI configuration files only; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The commit changes four YAML CI configuration/generated presubmit files only; no Ginkgo test code or Ginkgo constructs are changed.
Microshift Test Compatibility ✅ Passed The commit changes only CI YAML files; no Ginkgo test declarations or MicroShift-specific API references were added, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only CI config and generated presubmit YAML; it adds no Ginkgo e2e tests or multi-node test assumptions to assess.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI test skip settings and generated Prow annotations; it adds no deployment manifests, operator/controller code, or topology-related scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The patch changes only four YAML CI configuration/job files and adds no OTE binary or process-level code, so this stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only CI YAML and generated presubmit configuration; it adds no Ginkgo e2e tests or networking code to assess.
No-Weak-Crypto ✅ Passed The pull request changes only CI test skip settings and generated annotations; the exact patch contains no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The commit adds only test scheduling and pipeline-skip fields. Added-line and generated-job scans found no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only test scheduling and skip annotations; it adds no logging, command output, credentials, tokens, hostnames, or customer data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from eliorerz and gamli75 August 10, 2026 15:27
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants