Skip to content

ci: reduce ARO HCP dev e2e slots - #83190

Open
roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:dev-e2e-60-msi-slots
Open

ci: reduce ARO HCP dev e2e slots#83190
roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:dev-e2e-60-msi-slots

Conversation

@roivaz

@roivaz roivaz commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What

Reduce each of the four ARO HCP managed DEV E2E Boskos pools from six slots to five and regenerate _boskos.yaml.

Why

ARO HCP is increasing each DEV E2E job slot from 50 to 60 managed identity containers. Recent CI evidence shows all 50 containers are already used in one run, so further suite growth would make tests wait for containers and increase job duration:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/Azure_ARO-HCP/6477/pull-ci-Azure-ARO-HCP-main-e2e-parallel/2086800253519925248/artifacts/e2e-parallel/aro-hcp-test-local/artifacts/identities-pool-state.yaml

Changing from 6 x 50 to 5 x 60 preserves 300 identity containers per managed subscription while adding per-job headroom.

This shrinking Boskos change must roll out before the ARO-HCP catalog change. It prevents new jobs from acquiring slot 05; the corresponding Azure ARM stacks are intentionally left in place until a final manual cleanup after the coordinated rollout.

Testing

  • make update
  • ARO-HCP slot-manager validate-boskos-config
  • Boskos generation idempotence check

Coordination

Companion ARO-HCP draft PR: Azure/ARO-HCP#6491

Do not merge the ARO-HCP PR until this change has merged and rolled out.

Summary by CodeRabbit

  • Reduces each ARO HCP managed DEV E2E Boskos pool from six slots to five.
  • Increases each remaining slot from 50 to 60 managed identity containers.
  • Preserves 300 containers per managed subscription while increasing per-job capacity.
  • Prevents new jobs from acquiring slot 05; existing Azure ARM stacks remain available for manual cleanup.
  • Regenerates and validates _boskos.yaml with an idempotence check.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The ARO-HCP development resource configuration now provides five slots for each of shards 0–3. The slot generator and Boskos resource declarations are synchronized.

Changes

ARO-HCP slot reduction

Layer / File(s) Summary
Synchronize generated slot counts
core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml
The generator now creates five slots for each ARO-HCP development shard from 0 through 3. The Boskos configuration removes the fifth slot from each shard.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: josecastillolema, ibm-adarsh

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only Boskos YAML and Python loop bounds; no Ginkgo test files or It/Describe/Context/When titles are added or modified.
Test Structure And Quality ✅ Passed The pull request changes only Boskos YAML and a Python generator; it adds no Ginkgo It blocks or cluster-interacting test code to review.
Microshift Test Compatibility ✅ Passed The PR changes only Boskos YAML and its Python generator; it adds no Ginkgo e2e tests or MicroShift API/resource references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit adds no Ginkgo e2e tests; it only changes two Boskos configuration files, so SNO compatibility checks are not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only Boskos resource names and generator loop counts; it adds no deployment, operator, controller, or Kubernetes scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML and Python configuration files; it adds no OTE binary code or process-level stdout writes such as main(), RunSpecs(), or suite setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only Boskos YAML and slot-count generation. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The PR only changes Boskos slot counts and removes slot-05 names. Added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto API, or secret comparison.
Container-Privileges ✅ Passed The PR changes only Boskos YAML and its Python generator; neither file is a container manifest or contains privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff only changes slot counts and removes resource entries; AST found no logging/output calls, and added lines contain no sensitive-data terms.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: reducing ARO HCP development E2E slots.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@roivaz: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@roivaz
roivaz marked this pull request as ready for review August 10, 2026 16:01
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci
openshift-ci Bot requested review from deepsm007 and psalajova August 10, 2026 16:02
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@roivaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hbhushan3

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbhushan3, roivaz
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants