Skip to content

NO-JIRA: bump GCD Boskos leases from 2 to 7 - #83192

Open
rochacbruno wants to merge 1 commit into
openshift:mainfrom
rochacbruno:no-jira/bump-gcd-boskos-leases
Open

NO-JIRA: bump GCD Boskos leases from 2 to 7#83192
rochacbruno wants to merge 1 commit into
openshift:mainfrom
rochacbruno:no-jira/bump-gcd-boskos-leases

Conversation

@rochacbruno

@rochacbruno rochacbruno commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Increase gcd-quota-slice concurrent leases from 2 to 7 in u-germany-northeast1
  • GCD CI volume is growing and hitting the current lease limit
  • Firewall rule quota is comfortable: each cluster uses ~9-10 rules, adding 5 more leases adds ~50 rules against a 200 limit with current usage at ~65

Changes

  • core-services/prow/02_config/generate-boskos.py: bump gcd-quota-slice from 2 to 7
  • core-services/prow/02_config/_boskos.yaml: regenerated via make boskos-config

Test plan

  • Verify _boskos.yaml has 7 slices (gcd-quota-slice-0 through gcd-quota-slice-6)
  • Confirm CI jobs can acquire GCD leases after merge

Summary by CodeRabbit

  • Increased concurrent gcd-quota-slice leases in u-germany-northeast1 from 2 to 7.
  • Added five generated quota-slice resources to support growing GCD CI volume.
  • The additional leases are expected to use approximately 50 firewall rules, within the 200-rule quota.

Increase gcd-quota-slice concurrent leases in u-germany-northeast1
to accommodate growing CI volume on GCD.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rochacbruno: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Increase gcd-quota-slice concurrent leases from 2 to 7 in u-germany-northeast1
  • GCD CI volume is growing and hitting the current lease limit
  • Firewall rule quota is comfortable: each cluster uses ~9-10 rules, adding 5 more leases adds ~50 rules against a 200 limit with current usage at ~65

Changes

  • core-services/prow/02_config/generate-boskos.py: bump gcd-quota-slice from 2 to 7
  • core-services/prow/02_config/_boskos.yaml: regenerated via make boskos-config

Test plan

  • Verify _boskos.yaml has 7 slices (gcd-quota-slice-0 through gcd-quota-slice-6)
  • Confirm CI jobs can acquire GCD leases after merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ad0d4710-8797-4146-aedd-760e5a5e1cbf

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2a11c and 8b6749f.

📒 Files selected for processing (2)
  • core-services/prow/02_config/_boskos.yaml
  • core-services/prow/02_config/generate-boskos.py

Walkthrough

The u-germany-northeast1 gcd-quota-slice quota increases from 2 to 7. The Boskos configuration adds resource names for slices 2 through 6.

Changes

Boskos quota expansion

Layer / File(s) Summary
Quota and resource registration
core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml
The generator quota increases to 7, and the Boskos configuration adds five named resources for slices 2 through 6.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: roivaz, ibm-adarsh, josecastillolema

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: increasing GCD Boskos leases from 2 to 7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only Boskos quota configuration and adds no Ginkgo test titles or test code.
Test Structure And Quality ✅ Passed The PR changes only Boskos YAML and a Python generator; no Ginkgo test files or test constructs are present, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The patch changes only Boskos YAML and a Python quota setting; it adds no Ginkgo tests or MicroShift-incompatible test references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only Boskos YAML and a Python generator; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes Boskos quota configuration: five resource names and one lease-count value. It adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only a Python Boskos generator and YAML; no Go OTE binary, suite setup, or process-level stdout write is present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only Boskos YAML and its Python generator; it adds no Ginkgo e2e tests, IPv4 test logic, or external connectivity.
No-Weak-Crypto ✅ Passed The six added lines only increase quota-slice names and the count; changed files contain no weak-crypto algorithms, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR changes only Boskos quota configuration; added lines contain no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only quota resource names and a count; changed lines contain no logging calls or sensitive values, and the generator only writes YAML output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rochacbruno

Copy link
Copy Markdown
Member Author

/cc @patrickdillon @barbacbd

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rochacbruno: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@patrickdillon

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon, rochacbruno
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@rochacbruno: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants