[WINC-1971] [wmco] Optimize OTE job triggers and remove 0-test workaround by rrasouli · Pull Request #84352 · openshift/release

rrasouli · 2026-09-01T08:47:21Z

Follow-up to PR #83352 - now that proxy tests exist in master:

Skip redundant test runs:
- aws-e2e-ote skips when ONLY proxy.go changes
- vsphere-proxy-e2e-ote skips when ONLY winc.go changes
- Both jobs run when files are changed together or other code changes
Remove 0-test workaround from vsphere-proxy-e2e-ote:
- Replaced custom proxy-e2e-test-with-zero-handling step
- Now uses standard openshift-e2e-test ref
- Added TEST_SUITE=windows-machine-config-operator/proxy env var

This ensures:

Proxy changes only run proxy-specific tests (vsphere-proxy-e2e-ote)
Non-proxy OTE changes only run full suite (aws-e2e-ote)
No more 0-test workaround needed (WMCO PR Switch support-operator to golang-1.12 #4459 merged)

Related: #83352

This PR removes the zero-handling workaround from vsphere-proxy-e2e-ote job.

Note: This job will fail with "no tests to run" until WMCO PR #4459 merges.
Once #4459 merges to master, this job will automatically discover and run proxy tests.

Dependency: openshift/windows-machine-config-operator#4459

Reviewers: Please approve, but use /hold to block merge until WMCO #4459 lands.

Summary by CodeRabbit

Updates Windows Machine Config Operator OTE jobs in OpenShift CI.
AWS OTE skips runs when only proxy.go changes and excludes [node-proxy] tests.
vSphere proxy OTE skips runs when only winc.go changes.
Both jobs still run when these files change with other code.
Replaces the vSphere proxy job’s zero-test workaround with the standard openshift-e2e-test step.
Configures the proxy suite with TEST_SUITE=windows-machine-config-operator/proxy.

coderabbitai · 2026-09-01T08:47:59Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 05b02715-b94a-4138-82db-846a0b3b3df0

📥 Commits

Reviewing files that changed from the base of the PR and between 4d86e50 and f60e2ab.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Walkthrough

The CI configuration updates change-based skip rules for AWS and vSphere tests. The AWS test skips node-proxy tests. The vSphere proxy test uses the openshift-e2e-test ref with explicit suite and analyzer settings.

Changes

Windows OTE CI updates

Layer / File(s)	Summary
AWS proxy test filtering `ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml`	The AWS skip rule includes `ote/test/e2e/proxy.go`. The test sets `TEST_SKIPS` to skip `[node-proxy]` tests.
vSphere proxy test execution `ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml`	The vSphere skip rule includes `ote/test/e2e/winc.go`. The test sets `TEST_ARGS` and `TEST_SUITE`, then uses the `openshift-e2e-test` ref without custom zero-test handling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f60e2

The CI routing updates adjust proxy test triggers and use the standard vSphere proxy test configuration. No concrete merge-blocking risk remains in the supplied evidence.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: optimizing WMCO OTE job triggers and removing the zero-test workaround.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only CI configuration and generated presubmit metadata. The diff adds skip regexes, `TEST_SKIPS`, `TEST_ARGS`, `TEST_SUITE`, and replaces a test execution step. It does …
Test Structure And Quality	✅ Passed	PASS. The complete pull-request diff changes only CI YAML files. It adds OTE job filters and environment variables, replaces a shell test step with the standard `openshift-e2e-test` reference, and cha…
Microshift Test Compatibility	✅ Passed	PASS: The PR changes only CI configuration and generated presubmit YAML. The PR diff contains no Go-file changes and adds or modifies no Ginkgo declarations such as `It()` or `Describe()`. The MicroSh…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only CI configuration and generated presubmit metadata. The cumulative diff from the PR baseline contains no Go test-source changes and adds no `It()`, `Describe()`, `Co…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only CI configuration and generated Prow job annotations. The added lines modify skip regexes, test environment variables, and the `openshift-e2e-test` reference. No pod…
Ote Binary Stdout Contract	✅ Passed	PASS — The PR changes only CI YAML and generated Prow job metadata. The diff contains no Go or OTE implementation files and adds no process-level stdout writes, logging setup, or suite configuration. …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request changes only CI configuration and generated presubmit metadata. The complete PR diff contains no Go files, no added `It()`, `Describe()`, `Context()`, or `When()` declarations,…
No-Weak-Crypto	✅ Passed	PASS. The complete change range modifies only CI YAML and generated presubmit configuration. Added content contains test filters, suite arguments, skip regexes, and the `openshift-e2e-test` reference.…
Container-Privileges	✅ Passed	PASS: The pull request changes only test skip regexes, test environment variables, a test-step reference, and generated presubmit annotations. The added lines contain no `privileged: true`, `hostPID`,…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request changes CI skip regexes, test-selection environment variables, and the test step reference. It does not add logging, credentials, tokens, API keys, personal data, hostnames, session I…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only CI configuration and generated presubmit metadata. The diff adds skip regexes, TEST_SKIPS, TEST_ARGS, TEST_SUITE, and replaces a test execution step. It does not add or modify any Ginkgo It, Describe, Context, or When title, so no dynamic or overly specific test name was introduced.

Full details: Test Structure And Quality

Explanation

PASS. The complete pull-request diff changes only CI YAML files. It adds OTE job filters and environment variables, replaces a shell test step with the standard openshift-e2e-test reference, and changes no Ginkgo test source. The diff contains no It, BeforeEach, AfterEach, Eventually, Consistently, or assertion code. The standard reference defines a 14400-second timeout, and the existing setup step retains its 2h15m timeout. Therefore, none of the five stated Ginkgo test-quality failure conditions is introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The PR changes only CI configuration and generated presubmit YAML. The PR diff contains no Go-file changes and adds or modifies no Ginkgo declarations such as It() or Describe(). The MicroShift test compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only CI configuration and generated presubmit metadata. The cumulative diff from the PR baseline contains no Go test-source changes and adds no It(), Describe(), Context(), or When() declarations. Therefore, the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only CI configuration and generated Prow job annotations. The added lines modify skip regexes, test environment variables, and the openshift-e2e-test reference. No pod anti-affinity, topology spread constraint, replica calculation, node selector or affinity, toleration, or PDB was added or modified.

Full details: Ote Binary Stdout Contract

Explanation

PASS — The PR changes only CI YAML and generated Prow job metadata. The diff contains no Go or OTE implementation files and adds no process-level stdout writes, logging setup, or suite configuration. The changed shell step only invokes existing test commands; no custom OTE binary code is introduced.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request changes only CI configuration and generated presubmit metadata. The complete PR diff contains no Go files, no added It(), Describe(), Context(), or When() declarations, and no new e2e test code. Therefore, the IPv4 and disconnected-network test compatibility check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The complete change range modifies only CI YAML and generated presubmit configuration. Added content contains test filters, suite arguments, skip regexes, and the openshift-e2e-test reference. The added-line scan found no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or non-constant-time secret comparison usage.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only test skip regexes, test environment variables, a test-step reference, and generated presubmit annotations. The added lines contain no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or root runAsUser setting. The existing pod-security.kubernetes.io/enforce=privileged command is unchanged and is not a container privilege field introduced by this pull request.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request changes CI skip regexes, test-selection environment variables, and the test step reference. It does not add logging, credentials, tokens, API keys, personal data, hostnames, session IDs, or customer data. The removed workaround only deleted informational echo lines. No stated sensitive-data-in-logs condition is introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-09-01T14:14:36Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

rrasouli · 2026-09-01T14:18:57Z

/hold

rrasouli · 2026-09-01T14:21:06Z

/hold cancel

rrasouli · 2026-09-01T14:26:01Z

/pj-rehearse

rrasouli · 2026-09-01T14:26:28Z

/test all

openshift-merge-bot · 2026-09-01T14:30:39Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-01T15:02:28Z

@openshift/openshift-team-windows-containers PTAL

Replace broken 'openshift-tests run' command with the working 'openshift-tests-extension run' command that was in the original PR openshift#83352 commit before merge. The broken command doesn't discover OTE extensions even after openshift-tests-extension-setup-out-of-payload extracts them. Also remove TEST_ARGS and TEST_SUITE env vars that were only needed for the openshift-e2e-test ref approach. Follow-up to openshift#83352

coderabbitai · 2026-09-02T06:23:41Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

rrasouli · 2026-09-02T06:40:59Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-02T06:41:02Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-02T10:17:17Z

/test vsphere-proxy-e2e-ote

rrasouli · 2026-09-02T10:21:37Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

rrasouli · 2026-09-02T10:23:57Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-02T10:23:59Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-09-02T10:26:04Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-02T15:49:15Z

/assign @jrvaldes

rrasouli · 2026-09-02T17:47:43Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-02T17:49:54Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-02T20:57:02Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-02T20:57:05Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-03T03:33:05Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-03T03:33:07Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-03T11:52:23Z

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote

openshift-merge-bot · 2026-09-03T11:53:02Z

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rrasouli · 2026-09-03T15:55:39Z

@jrvaldes please approve, test works 3 issues will be addressed on openshift/windows-machine-config-operator#4571

openshift-ci · 2026-09-03T16:33:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrasouli
Once this PR has been reviewed and has the lgtm label, please ask for approval from jrvaldes. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add TEST_SKIP: '\[node-proxy\]' to aws-e2e-ote to exclude proxy tests from running on non-proxy AWS clusters. Proxy tests require a proxy-configured cluster and should only run on vsphere-proxy-e2e-ote job. This prevents proxy test failures on aws-e2e-ote while still running all other OTE tests.

coderabbitai · 2026-09-03T16:54:19Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-09-03T16:57:11Z

[REHEARSALNOTIFIER]
@rrasouli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-ote	openshift/windows-machine-config-operator	presubmit	Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote	openshift/windows-machine-config-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-09-03T17:13:16Z

@rrasouli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/windows-machine-config-operator/master/aws-e2e-ote	`45c4798`	link	unknown	`/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-ote`
ci/rehearse/openshift/windows-machine-config-operator/master/vsphere-proxy-e2e-ote	`6c09355`	link	unknown	`/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from jrvaldes and wgahnagl September 1, 2026 08:48

rrasouli force-pushed the winc-skip-proxy-in-aws-ote branch from 2247d12 to 45c4798 Compare September 1, 2026 14:14

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026

rrasouli force-pushed the winc-skip-proxy-in-aws-ote branch from 45c4798 to 6c09355 Compare September 2, 2026 06:23

rrasouli changed the title ~~[wmco] Optimize OTE job triggers and remove 0-test workaround~~ [DO NOT MERGE] [wmco] Optimize OTE job triggers and remove 0-test workaround Sep 2, 2026

rrasouli changed the title ~~[DO NOT MERGE] [wmco] Optimize OTE job triggers and remove 0-test workaround~~ [wmco] Optimize OTE job triggers and remove 0-test workaround Sep 2, 2026

jrvaldes reviewed Sep 2, 2026

View reviewed changes

Comment thread ...nshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

openshift-ci Bot assigned jrvaldes Sep 2, 2026

rrasouli mentioned this pull request Sep 3, 2026

[WINC-1971] [ote] Fix OCP-68320 test missing SpecContext parameter openshift/windows-machine-config-operator#4566

Merged

rrasouli changed the title ~~[wmco] Optimize OTE job triggers and remove 0-test workaround~~ [WINC-1971] [wmco] Optimize OTE job triggers and remove 0-test workaround Sep 3, 2026

rrasouli force-pushed the winc-skip-proxy-in-aws-ote branch from 3c693f2 to f60e2ab Compare September 3, 2026 16:54

Uh oh!

Conversation

rrasouli commented Sep 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot commented Sep 1, 2026

Uh oh!

rrasouli commented Sep 1, 2026

Uh oh!

rrasouli commented Sep 1, 2026

Uh oh!

rrasouli commented Sep 1, 2026

Uh oh!

rrasouli commented Sep 1, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 1, 2026

Uh oh!

rrasouli commented Sep 1, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

rrasouli commented Sep 3, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 3, 2026

Uh oh!

rrasouli commented Sep 3, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 3, 2026

Uh oh!

rrasouli commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

coderabbitai Bot commented Sep 3, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rrasouli commented Sep 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading