Switch support-operator to golang-1.12 - #4459
Merged
Merged
Conversation
openshift-ci-robot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
@eparis as I'm cleaning up this stuff (will tag you on a few things next week) |
Contributor
|
@smarterclayton: Updated the following 6 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rrasouli
added a commit
to rrasouli/release
that referenced
this pull request
Aug 27, 2026
The vsphere-proxy-e2e-ote job is failing rehearsal because master doesn't have the proxy test code yet (pending merge of WMCO PR openshift#4459). Making it optional (like aws-e2e-ote) allows the release PR to merge. Once openshift#4459 merges to WMCO master, a follow-up PR can remove the optional flag and the job will work correctly.
rrasouli
added a commit
to rrasouli/release
that referenced
this pull request
Aug 27, 2026
Adds standalone vsphere-proxy-e2e-ote job that runs OTE proxy tests on a vsphere proxy cluster using the windows-machine-config-operator/proxy test suite. Temporary workaround: Uses custom inline test step instead of the standard openshift-e2e-test ref to handle 0 tests gracefully. This is needed because the proxy test code (proxy.go) is in WMCO PR openshift#4459 which hasn't merged yet. Rehearsal runs against current WMCO master which only has the suite registration but not the test file itself. The custom step: - Runs openshift-tests-extension with the proxy suite - If exit code 1 AND output contains "no tests to run" → exit 0 (PASS) - Otherwise → pass through original exit code - Once openshift#4459 merges: proxy tests exist → runs normally with test results Cleanup (after WMCO PR openshift#4459 is stable): Create follow-up PR to replace the custom inline step with: - ref: openshift-e2e-test Related: openshift/windows-machine-config-operator#4460
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
* WINC-1971: Add standalone OTE proxy suite job for vsphere Adds a new vsphere-proxy-e2e-ote job that runs OTE proxy tests on a vsphere proxy cluster. This is a separate job from the existing vsphere-proxy-e2e-operator to keep complexity isolated per reviewer feedback. Signed-off-by: rrasouli <rrasouli@redhat.com> * Add vsphere-proxy-e2e-ote job with 0-test handling Adds standalone vsphere-proxy-e2e-ote job that runs OTE proxy tests on a vsphere proxy cluster using the windows-machine-config-operator/proxy test suite. Temporary workaround: Uses custom inline test step instead of the standard openshift-e2e-test ref to handle 0 tests gracefully. This is needed because the proxy test code (proxy.go) is in WMCO PR #4459 which hasn't merged yet. Rehearsal runs against current WMCO master which only has the suite registration but not the test file itself. The custom step: - Runs openshift-tests-extension with the proxy suite - If exit code 1 AND output contains "no tests to run" → exit 0 (PASS) - Otherwise → pass through original exit code - Once #4459 merges: proxy tests exist → runs normally with test results Cleanup (after WMCO PR #4459 is stable): Create follow-up PR to replace the custom inline step with: - ref: openshift-e2e-test Related: openshift/windows-machine-config-operator#4460 * Add wmco-setup step to create Windows nodes in proxy environment --------- Signed-off-by: rrasouli <rrasouli@redhat.com> Co-authored-by: openshift-ci[bot] <75433959+openshift-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed in order to bump vendor to 1.14 levels of apimachinery, client-go, and library-go