Skip to content

SPLAT-2948: Shard vSphere TechPreview Serial jobs - #84614

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
vr4manta:SPLAT-2948
Sep 4, 2026
Merged

SPLAT-2948: Shard vSphere TechPreview Serial jobs#84614
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
vr4manta:SPLAT-2948

Conversation

@vr4manta

@vr4manta vr4manta commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

SPLAT-2948

Changes

  • Shard vSphere TechPreview Serial jobs (4.22, 4.23, 5.0, 5.1)
  • Shard vSphere Zones TechPreview Serial jobs (4.22, 4.23, 5.0, 5.1)

Summary by CodeRabbit

This change updates OpenShift nightly CI and release verification for vSphere TechPreview tests in versions 4.22, 4.23, 5.0, and 5.1.

  • Configures vSphere TechPreview serial jobs to run with two shards.
  • Adds vSphere Zones TechPreview jobs for 4.23.
  • Replaces single release verification jobs with separate optional jobs for shards 1 of 2 and 2 of 2.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

SPLAT-2948

Changes

  • Shard vSphere TechPreview Serial jobs (4.22, 4.23, 5.0, 5.1)
  • Shard vSphere Zones TechPreview Serial jobs (4.22, 4.23, 5.0, 5.1)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 00c2c003-6ca7-46c9-99e1-8437bd1fd4c0

📥 Commits

Reviewing files that changed from the base of the PR and between 272bcd3 and c90bd5b.

📒 Files selected for processing (6)
  • core-services/release-controller/_releases/priv/release-ocp-4.22.json
  • core-services/release-controller/_releases/priv/release-ocp-5.0.json
  • core-services/release-controller/_releases/priv/release-ocp-5.1.json
  • core-services/release-controller/_releases/release-ocp-4.22.json
  • core-services/release-controller/_releases/release-ocp-5.0.json
  • core-services/release-controller/_releases/release-ocp-5.1.json

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The nightly release configurations shard vSphere TechPreview serial jobs across releases 4.22, 4.23, 5.0, and 5.1. Release 4.23 also adds scheduled vSphere zones TechPreview jobs. Release verification entries map the two shards to separate Prow jobs.

Changes

vSphere TechPreview sharding

Layer / File(s) Summary
Nightly test configuration
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml
Existing vSphere TechPreview serial jobs now use two shards. Release 4.23 adds scheduled vSphere zones TechPreview parallel and serial conformance jobs.
Release verification mapping
core-services/release-controller/_releases/**/*.json
Each release replaces the single vSphere OVN TechPreview serial verification entry with 1of2 and 2of2 entries mapped to separate Prow jobs. The entries remain optional, and the private entries remain disabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c90bd

vSphere TechPreview serial verification is split into two separately mapped shards across the affected releases. The supplied configuration evidence shows consistent shard mappings, with no current merge-readiness risk identified.

Suggested reviewers: redhat-chai-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: sharding vSphere TechPreview serial jobs. It is directly related to the changeset, although it does not mention the additional vSphere Zones …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only CI YAML and release-controller JSON configuration. The complete PR range contains no Go, JavaScript/TypeScript, Ginkgo, or test-source files, and no changed It, `…
Test Structure And Quality ✅ Passed PASS: The pull request changes only CI/release configuration files (.yaml and .json). The diff adds shard settings, scheduled Prow jobs, and release-controller job mappings. It does not add or mod…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only CI job YAML and release-controller JSON. The diff adds shard and job metadata, and it adds no Ginkgo test source or new It, Describe, Context, or When test. Therefo…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only YAML and JSON CI/release configuration. The three commits add or shard existing vSphere jobs and add no Go or other test source, Ginkgo declarations, or new e2e tes…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes CI test configuration and release verification mappings only. The base-to-tip diff contains shard_count: 2, generated Prow job names and shard arguments, and release-c…
Ote Binary Stdout Contract ✅ Passed PASS: The PR changes only YAML/JSON configuration and generated Prow job definitions. The added behavior is shard_count: 2 and SHARD_ARGS shard IDs. The diff contains no process-level source code …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request adds and shards CI configuration only. The complete feature diff contains YAML and JSON changes, with no Go, JavaScript, TypeScript, Python, or other test-source files. No added…
No-Weak-Crypto ✅ Passed PASS. The PR changes only CI/Prow and release-controller configuration for vSphere job sharding. The complete diff from the PR base adds shard settings, job names, shard arguments, and Kubernetes secr…
Container-Privileges ✅ Passed PASS. The PR diff adds only shard settings, Prow job names/arguments, and release-controller job mappings. No added line sets privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes CI and release configuration only. The new reporting text contains job names, status, and standard Prow log links; it adds no passwords, tokens, API keys, PII, customer …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from smg247 and sosiouxme September 4, 2026 13:39
@vr4manta

vr4manta commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-zones-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-vsphere-ovn-zones-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-zones-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-zones-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-vsphere-ovn-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-vsphere-ovn-zones-techpreview-serial-2of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-vsphere-ovn-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-zones-techpreview-serial-1of2 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-zones-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2026
@xueqzhan

xueqzhan commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, vr4manta, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2026
@vr4manta

vr4manta commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit b58a3a4 into openshift:main Sep 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants