Skip to content

remove private vSphere periodic jobs - #84643

Open
jcpowermac wants to merge 1 commit into
openshift:mainfrom
jcpowermac:remove-priv-vsphere-jobs
Open

remove private vSphere periodic jobs#84643
jcpowermac wants to merge 1 commit into
openshift:mainfrom
jcpowermac:remove-priv-vsphere-jobs

Conversation

@jcpowermac

@jcpowermac jcpowermac commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Remove the private vSphere periodic test entries from the ci-operator configs, keeping only jobs matching agent, machine-config, mco, wmco, or windows.

  • remove 1222 matched test entries from 99 configs in openshift-tests-private and verification-tests
  • delete 4 variant configs left with no tests
  • regenerate ci-operator/jobs/ via make update

Verified against the private Prow deck export: all 940 target jobs are gone from the generated jobs and all 181 kept jobs (agent-qe-infra, mco) remain. The 2 installer-rehearse jobs are defined outside this repo and are unaffected.

Summary by CodeRabbit

  • Removed 1,222 private vSphere periodic test entries from 99 openshift-tests-private and verification-tests configurations.
  • Retained jobs that match agent, machine-config, MCO, WMCO, or Windows coverage.
  • Deleted four variant configurations that no longer contained tests.
  • Regenerated ci-operator/jobs/ with make update.
  • Verified the change against the private Prow deck export: 940 target jobs were removed and 181 retained jobs remain.
  • Two externally defined installer-rehearse jobs are unaffected.

Remove the private vSphere periodic test entries from the ci-operator
configs, keeping only jobs matching agent, machine-config, mco, wmco, or
windows.

- remove 1222 matched test entries from 99 configs in
  openshift-tests-private and verification-tests
- delete 4 variant configs left with no tests
- regenerate ci-operator/jobs/ via make update

Verified against the private Prow deck export: all 940 target jobs are
gone from the generated jobs and all 181 kept jobs
(agent-qe-infra, mco) remain. The 2 installer-rehearse jobs are defined
outside this repo and are unaffected.
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Removed vSphere test configurations from OpenShift private-test and verification-test schedules across releases 4.12 through 5.1. The changes remove installation, upgrade, rollback, rehearsal, Windows-container, and specialized coverage jobs.

Changes

vSphere private-test configurations

Layer / File(s) Summary
Private nightly test coverage
ci-operator/config/openshift/openshift-tests-private/*nightly.yaml
Removed broad vSphere nightly coverage across installation, networking, encryption, migration, platform, Windows-container, and certificate-rotation scenarios. Added selected migration and destructive test jobs in 4.15 and 4.16.
Private upgrade and rollback coverage
ci-operator/config/openshift/openshift-tests-private/*upgrade*.yaml, *rollback-nightly.yaml, *stable*.yaml
Removed vSphere upgrade, rollback, CPU-upgrade, stable, and multi-nightly jobs, including schedules, profiles, leases, environment settings, workflows, and test chains.

Verification-test configurations

Layer / File(s) Summary
Installation verification and installer rehearsal coverage
ci-operator/config/openshift/verification-tests/*installation-nightly*.yaml, *installer-rehearse*.yaml
Removed vSphere disk-type, customized-resource, invalid-field, connected, and disconnected installer verification and rehearsal jobs from releases 4.12 through 5.1.

Estimated code review effort: 4 (Complex) | ~60 minutes

Merge Risk: ⚪ Minimal · up to 6f00f

This change removes the targeted private vSphere CI schedules and regenerated job definitions. No concrete merge-blocking impact is identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removal of private vSphere periodic jobs from CI configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes 117 YAML files only, all under ci-operator/config or ci-operator/jobs. The patch removes or regenerates CI job configuration and adds no Ginkgo title calls or title/desc…
Test Structure And Quality ✅ Passed PASS: The check is not applicable to this pull request. The commit changes 117 YAML configuration/generated-job files only; no Go or other test-source files are changed. Representative diffs remove CI…
Microshift Test Compatibility ✅ Passed The check is not applicable to this pull request. The commit changes 117 YAML files under ci-operator/config and ci-operator/jobs. Source configuration changes contain 0 additions and 12,005 deletions…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo tests. The HEAD diff changes 117 YAML files only, with configuration changes consisting of deletions. No added lines contain Ginkgo declarations such as It, Descr…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/** and generated ci-operator/jobs/** YAML files. The representative source diff removes vSphere test entries, and the generated files contain…
Ote Binary Stdout Contract ✅ Passed The pull request changes 117 files, and every changed file is YAML under ci-operator/config or generated ci-operator/jobs. The diff removes test configuration entries and generated job definitions…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only YAML CI configuration and generated job files. The diff adds no configuration lines, no source files, and no Ginkgo declarations such as It(), Describe(), Context()…
No-Weak-Crypto ✅ Passed The pull request changes only YAML configuration and generated job files. The source configuration changes contain 0 additions and 12,005 deletions. All 40,420 added generated-job lines already existe…
Container-Privileges ✅ Passed The pull request does not introduce a container privilege violation. The diff adds no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or explici…
No-Sensitive-Data-In-Logs ✅ Passed PASS — The pull request introduces no logging or sensitive-data output. All source config diffs contain 0 additions and only remove test entries. Generated job files show only removed job objects; eve…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from dis016 and jechen0648 September 4, 2026 17:23
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jcpowermac: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@jcpowermac

Copy link
Copy Markdown
Contributor Author

As far as I know, no one (at least from SPLAT) are monitoring these jobs. I didn't include MCO, Agent or Windows MCO jobs since they could still be in use.

We are having to shard: #84614 so we will need more capacity for jobs that will actually be reviewed.

/assign @mffiedler @jogeo @vr4manta

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta

vr4manta commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, vr4manta
Once this PR has been reviewed and has the lgtm label, please assign pruan-rht for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants