Skip to content

Remove the WeBWorK SOAP service. #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somiaj merged 1 commit into from
Aug 3, 2026
Merged

Remove the WeBWorK SOAP service. #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,6 @@ RUN apt-get update \
libpath-tiny-perl \
libperl-critic-perl \
libphp-serialization-perl \
libpod-wsdl-perl \
libsoap-lite-perl \
libsql-abstract-perl \
libssl-dev \
libstring-shellquote-perl \
Expand Down
2 changes: 0 additions & 2 deletions DockerfileStage1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ RUN apt-get update \
libpath-tiny-perl \
libperl-critic-perl \
libphp-serialization-perl \
libpod-wsdl-perl \
libsoap-lite-perl \
libsql-abstract-perl \
libssl-dev \
libstring-shellquote-perl \
Expand Down
11 changes: 0 additions & 11 deletions bin/check_modules.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,17 +427,6 @@ =head1 DESCRIPTION
rhel => 'perl-Pod-Usage'
}
},
'Pod::WSDL' => {
package => {
ubuntu => 'libpod-wsdl-perl'
}
},
'SOAP::Lite' => {
package => {
ubuntu => 'libsoap-lite-perl',
rhel => 'perl-SOAP-Lite'
}
},
'SQL::Abstract' => {
minversion => '2',
package => {
Expand Down
5 changes: 0 additions & 5 deletions conf/webwork2.mojolicious.dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ JSON_ERROR_LOG: 0
# does not forward the server root location.
#server_root_url_redirect: https://mysite.edu/mypage.html

# Uncomment the line below to use the WebworkSOAP handlers. Make sure that you
# change the value to something more secure. Note that it must consist entirely
# of digits.
#soap_authen_key: 123456789123456789

# If a remote site is using this WW server to process WW problems and embed them
# into web pages, the web browser might not permit the WW problems to be
# displayed, as it violates security policy to mix content from different
Expand Down
17 changes: 0 additions & 17 deletions lib/Mojolicious/WeBWorK.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,23 +228,6 @@ sub startup ($app) {
}
);

if ($config->{soap_authen_key}) {
# Only allow an authen key that consists entirely of digits. The WebworkSOAP module uses a numeric != for
# comparison, and in perl all strings containing alphabetic characters are numerically equal. So if this is not
# numeric all keys that are passed in will succeed in authentication. Very dangerous!
if ($config->{soap_authen_key} =~ /^\d*$/) {
$app->log->info('SOAP endpoints enabled');
$WeBWorK::SeedCE{soap_authen_key} = $config->{soap_authen_key};

push(@{ $r->namespaces }, 'WebworkSOAP');
$r->any('/webwork2_wsdl')->to('SOAP#wsdl');
$r->post('/webwork2_rpc')->to('SOAP#dispatch');
} else {
$app->log->info(qq{Invalid soap_authen_key "$config->{soap_authen_key}". }
. 'It must consist entirely of digits. SOAP endpoints NOT enabled.');
}
}

# Letsencrypt renewal route.
if ($config->{enable_certbot_webroot_routes}) {
$r->any(
Expand Down
Loading