Make sure to account for an undefined ANSWER_ENTRY_ORDER in the single problem grader. - #3195
Conversation
|
It seems to me that the fact that the problem does not render reveals a fundamental flaw in PG. The |
|
When testing this out, I noticed that some users the problem grader has a comment field and others don't, what is the logic for if it is possible for the instructor to add a comment with the single problem grader? |
Note, @dlglin pointed out a few other issues with PGbasicmacros.pl requiring stuff from PGauxiliaryFunctions.pl, and basically PG has issues and isn't well tested in the case PGstandard.pl is not loaded. Either we start just loading PGstandard.pl by default, or we fix those issues is my thought. |
|
The comments are saved in the past answer table. So in order for there to be a place to save the comment, there must be a past answer. So if the student has not submitted an answer, there is no comment field. |
a8ea5fc to
fb937ae
Compare
…gle problem grader. Previously the problem grader could only be made visible when the problem successfully rendered. Now that it is always visible, a little more care is needed. The `ANSWER_ENTRY_ORDER` array in the PG flags will not be defined if the problem does not successfully render. This fixes issue openwebwork#3194.
fb937ae to
fd3e269
Compare
…er-hotfix Make sure to account for an undefined `ANSWER_ENTRY_ORDER` in the single problem grader. (Hotfix of #3195)
|
Using @Alex-Jordan approval on #3196 as an approval on this too, and merging. |
Previously the problem grader could only be made visible when the problem successfully rendered. Now that it is always visible, a little more care is needed. The
ANSWER_ENTRY_ORDERarray in the PG flags will not be defined if the problem does not successfully render.This fixes issue #3194.