Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Feb 22, 2025

Replaces #278

@opsmill/backend FYI, I had to disable the test integration-tests-local-infrahub because the version of infrahub-testcontainers currently in pypi is not compatible with the version of infrahub we have in develop right now.

LucasG0 and others added 18 commits January 24, 2025 11:46
Run CI tests against multiple versions
…ethods

Update InfrahubNode artifact_fetch and artifact_generate methods to use artiface name instead of the defintion name
* Get default branch from env

* Add comment on all hardcoded main branch to be fixed later

* Add release note
* Refactor repository to not create blank credentials. Remove commit option in favor of ref option to match API and allow setting the ref on CTL.

* Format/Lint.

* Fixed payload between CoreRepositoryCreate and CoreReadOnlyRepositoryCreate mutations.
Move the function `read_file` from the ctl module to the SDK.
…274)

* Test building in logger to InfrahubGenerator class to allow logs to be easily propagated via CTL and CI pipeline logs.

* Remove unused logging import.

* Add changelog to describe change.
…TL commands (#270)

* Remove default value main for branch parameter

* Changelog

* Remove branch parameter from repository commands as node is branch agnostic

* Add None for username

* Remove branch parameter from tests

* Remove branch parameter from test

* Add option to list repository by branch

* Adjust parameter help
Fix typing for Python 3.9 and remove support for Python 3.13
@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Feb 22, 2025
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 69.49153% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/testing/docker.py 0.00% 15 Missing ⚠️
infrahub_sdk/ctl/cli_commands.py 50.00% 1 Missing ⚠️
infrahub_sdk/ctl/generator.py 66.66% 1 Missing ⚠️
infrahub_sdk/generator.py 50.00% 1 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
- Coverage    70.37%   66.88%   -3.49%     
===========================================
  Files           82       81       -1     
  Lines         7503     7505       +2     
  Branches      1391     1463      +72     
===========================================
- Hits          5280     5020     -260     
- Misses        1849     2099     +250     
- Partials       374      386      +12     
Flag Coverage Δ
integration-tests ?
python-3.10 45.50% <61.01%> (-0.03%) ⬇️
python-3.11 45.50% <61.01%> (-0.03%) ⬇️
python-3.12 45.50% <61.01%> (-0.03%) ⬇️
python-3.13 ?
python-3.9 44.32% <61.01%> (-1.20%) ⬇️
python-filler-3.12 23.99% <8.47%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/check.py 27.04% <100.00%> (ø)
infrahub_sdk/ctl/exceptions.py 60.00% <ø> (-17.78%) ⬇️
infrahub_sdk/ctl/exporter.py 50.00% <ø> (ø)
infrahub_sdk/ctl/importer.py 59.09% <100.00%> (+1.94%) ⬆️
infrahub_sdk/ctl/menu.py 65.38% <ø> (ø)
infrahub_sdk/ctl/object.py 65.38% <ø> (ø)
infrahub_sdk/ctl/repository.py 81.81% <100.00%> (+1.26%) ⬆️
infrahub_sdk/ctl/schema.py 55.83% <ø> (ø)
infrahub_sdk/ctl/utils.py 66.42% <100.00%> (ø)
infrahub_sdk/ctl/validate.py 53.52% <100.00%> (+0.66%) ⬆️
... and 8 more

... and 11 files with indirect coverage changes

@dgarros dgarros marked this pull request as ready for review February 22, 2025 14:55
@dgarros dgarros merged commit 825363c into develop Feb 22, 2025
13 checks passed
@dgarros dgarros deleted the dga-20250222-stable-develop branch February 22, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants