Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Run End to End Tests before Release#271

Closed
trulyronak wants to merge 16 commits intoopticdev:developfrom
trulyronak:ronakshah/better-release
Closed

Run End to End Tests before Release#271
trulyronak wants to merge 16 commits intoopticdev:developfrom
trulyronak:ronakshah/better-release

Conversation

@trulyronak
Copy link
Copy Markdown

This runs optic's end-to-end tests before any release, blocking release if they do not pass.

Before merging, note that will require a new org secret — a repo access token for end-to-end tests, called END_TO_END_ACCESS_KEY

@trulyronak
Copy link
Copy Markdown
Author

Note — it's currently not succeeding (https://github.com/trulyronak/optic/runs/879648850?check_suite_focus=true)

@acunniffe
Copy link
Copy Markdown
Member

@trulyronak what's required to put this over the edge? Nice work

@trulyronak
Copy link
Copy Markdown
Author

Currently just trying to get the tests to pass — as of now it seems to be running into Docker / port issues, I'm working with @devdoshi to figure it out

@trulyronak trulyronak marked this pull request as ready for review July 17, 2020 17:56
@trulyronak
Copy link
Copy Markdown
Author

It's in a functional state now (thanks to @devdoshi for helping me getting it to run), but it looks like it's still failing some tests — https://github.com/trulyronak/optic/runs/882855790?check_suite_focus=true

@acunniffe
Copy link
Copy Markdown
Member

@devdoshi @trulyronak I updated the tests to skip the failing one, but things seem to be in a weird state with the PR. In the check I'm getting 'can't find token' and the source of the PR says 'unknown repository'

@trulyronak
Copy link
Copy Markdown
Author

Oh yes — I was running it on my repo until this stage — we'll need a secret called END_TO_END_ACCESS_KEY which is a repository access token for the end-to-end test repo

@trulyronak
Copy link
Copy Markdown
Author

Closing this in favor of #291 - I accidentally deleted the fork that held this code, so I moved it over to a branch

@trulyronak trulyronak closed this Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants