Run End to End Tests before Release#271
Run End to End Tests before Release#271trulyronak wants to merge 16 commits intoopticdev:developfrom trulyronak:ronakshah/better-release
Conversation
|
Note — it's currently not succeeding (https://github.com/trulyronak/optic/runs/879648850?check_suite_focus=true) |
|
@trulyronak what's required to put this over the edge? Nice work |
|
Currently just trying to get the tests to pass — as of now it seems to be running into Docker / port issues, I'm working with @devdoshi to figure it out |
|
It's in a functional state now (thanks to @devdoshi for helping me getting it to run), but it looks like it's still failing some tests — https://github.com/trulyronak/optic/runs/882855790?check_suite_focus=true |
|
@devdoshi @trulyronak I updated the tests to skip the failing one, but things seem to be in a weird state with the PR. In the check I'm getting 'can't find token' and the source of the PR says 'unknown repository' |
|
Oh yes — I was running it on my repo until this stage — we'll need a secret called |
|
Closing this in favor of #291 - I accidentally deleted the fork that held this code, so I moved it over to a branch |
This runs optic's end-to-end tests before any release, blocking release if they do not pass.
Before merging, note that will require a new org secret — a repo access token for end-to-end tests, called
END_TO_END_ACCESS_KEY