Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Run End to End Tests before Release #271 #291

Merged
devdoshi merged 2 commits intodevelopfrom
ronakshah/end-to-end
Jul 24, 2020
Merged

Run End to End Tests before Release #271 #291
devdoshi merged 2 commits intodevelopfrom
ronakshah/end-to-end

Conversation

@trulyronak
Copy link
Copy Markdown

This runs optic's end-to-end tests before any release, blocking release if they do not pass.

Before merging, note that will require a new org secret — a repo access token for end-to-end tests, called END_TO_END_ACCESS_KEY

After adding the END_TO_END_ACCESS_KEY token to the org secrets, this should be good to go

push:
branches:
- develop
- release
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is one thing I'm not sure about — when should the end-to-end tests run? Right now I have it on any PR to develop or release, should I also be having it run once they merge into develop and release as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now, I'll be working on the e2e suite so I'll revisit once I look at it a bit more

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has been automatically deployed to FeaturePeek. ✌️
Your deployment will be kept up-to-date with this pull request's latest changes.

https://peek.run/4l0hj6g1


Please read our docs for more configuration details.

@trulyronak
Copy link
Copy Markdown
Author

right now you can see that the tests fail since the END_TO_END_ACCESS_KEY doesn't yet exist - this should be set to be some repo_access_token that can read the optic_end_to_end_tests

@devdoshi
Copy link
Copy Markdown
Contributor

I added the token, waiting for it to finish running now

@devdoshi devdoshi merged commit 318ae5a into develop Jul 24, 2020
@notnmeyer notnmeyer deleted the ronakshah/end-to-end branch February 15, 2021 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants