feat: detect cargo-dist in Packaging check - #5146
Open
SebTardif wants to merge 1 commit into
Open
Conversation
Rust repos that release via axodotdev cargo-dist (`dist plan` / `dist build`) were scoring Packaging -1 even when they publish multi-platform artifacts on every release. The existing Rust matcher only looks for `cargo publish`. Add a JobMatcher for cargo-dist CLI usage and fixtures for positive and false-positive cases. Fixes ossf#5145 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
requested review from
AdamKorcz and
spencerschrock
and removed request for
a team
July 27, 2026 20:43
dosubot
Bot
added
the
size:S
1 task
SebTardif
added a commit
to patchloom/patchloom
that referenced
this pull request
Jul 27, 2026
## Summary Updates `SECURITY.md` OpenSSF Packaging false-negative note with: - Root cause (cargo-dist `dist plan`/`dist build` not matched; only bare `cargo publish`) - Upstream issue: ossf/scorecard#5145 - Upstream PR: ossf/scorecard#5146 - Note that npm publish in the same workflow can yield Packaging 10 without detecting cargo-dist ## Test plan - [x] Re-read SECURITY.md table for accuracy against live `scorecard --checks=Packaging` on patchloom (10 via npm job line) Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Packaging check did not recognize cargo-dist (axodotdev) release workflows. Rust projects that use
dist plan/dist buildfor multi-platform GitHub Release artifacts (often without a top-level barecargo publishstep) scored Packaging -1 / "packaging workflow not detected".This is the same class of matcher gap as #5131 (goreleaser fork), #5096 (changesets), and #5133 (ko dual setup).
Fixes #5145
Changes
JobMatcherfor cargo-dist CLI:dist plan|build|publishorcargo distTestIsPackagingWorkflowNotes
cargo.*publishmatcher is unchanged.workflow_call-onlycargo publishfiles still need successful run attribution to credit Packaging (called out in Feature: Packaging check should detect cargo-dist (axodotdev) Rust release workflows #5145 as a secondary issue); this PR only adds cargo-dist detection.Test plan
go test ./checks/fileparser/ -run TestIsPackagingWorkflow -count=1