AO3-4862 Extending work controller test coverage by hatal175 · Pull Request #3165 · otwcode/otwarchive

hatal175 · 2017-11-17T14:40:03Z

Issue

https://otwarchive.atlassian.net/browse/AO3-4862

Purpose

This PR extends the test coverage for works controller.

I've also made a few changes for this purpose and I would really appreciate a review on them:

I've added a route for show_multiple under pseuds so you can see and edit only the works under that pseud.
I've deleted a code path in preview_mode that could not really be reached in current code base.
Deleted unused function tag_list
various bug fixes in previously uncovered code.

Testing

Run tests and see coverage improvement.

Credit

Tal Hayon

Please use he.

Also implemented show multiple for pseuds

- Added edit multiple works for pseud - Removed several dead code paths

houndci-bot · 2017-11-17T14:40:15Z

+      let(:work_params) {
+        {
+            work: {
+                summary: "a" * (ArchiveConfig.SUMMARY_MAX + 1),


Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

houndci-bot · 2017-11-17T14:40:16Z

+    context 'when work parameters are invalid' do
+      let(:work_params) {
+        {
+            work: {


Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

houndci-bot · 2017-11-17T14:40:16Z

    end

+    context 'when work parameters are invalid' do
+      let(:work_params) {


Avoid using {...} for multi-line blocks.

houndci-bot · 2017-11-17T14:40:16Z

+    it "should throw error when there are invalid tags and trying to preview" do
+      allow_any_instance_of(Work).to receive(:invalid_tags).and_return([create(:unsorted_tag)])
+
+      expect {patch :update_tags, params: { id: work, preview_button: true } }.to raise_error UncaughtThrowError


Space missing inside {.

houndci-bot · 2017-11-17T14:40:16Z

+        end
+
+        it "should show results" do
+          get :collected, params: { user_id: collected_user.login, work_search: { query: "fandom_ids:#{collected_fandom.id}" }}


Space inside } missing.

houndci-bot · 2017-11-17T14:40:16Z


+  describe "edit" do
+    let(:user) { create(:user) }
+    let(:work) {


Avoid using {...} for multi-line blocks.

sarken · 2018-06-29T02:28:16Z

Thanks for the pull request! However, this appears to have gone a bit beyond the scope of the issue, which just calls for the test coverage to be extended. We really do appreciate the bug fixes, but for numerous reasons, we prefer small pull requests that match the issue as closely as possible.

Before we can review this, we'd appreciate it if you could reduce its scope a bit.

I've added a route for show_multiple under pseuds so you can see and edit only the works under that pseud.

This isn't something we've had any requests for and aren't currently interested in implementing.

I've deleted a code path in preview_mode that could not really be reached in current code base.

Hound had an additional comment on this regarding a lingering unused argument. Ultimately, this seems like more of a refactor of the method than a simple deletion of unused code, so we'll make an issue for that once we know what to test to make sure the method still works.

Deleted unused function tag_list

We've made a separate issue for this: AO3-5457

various bug fixes in previously uncovered code.

We'll need a detailed list of the bugs and descriptions of how to manually reproduce them (whenever possible) to make issues as appropriate.

You can either give us the info here or email otw-coders@transformativeworks.org with the details -- whichever is easier.

Thanks again!

houndci-bot · 2018-07-07T07:01:27Z

+      let(:work_params) {
+        {
+            work: {
+                summary: "a" * (ArchiveConfig.SUMMARY_MAX + 1),


Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.

houndci-bot · 2018-07-07T07:01:27Z

+    context "when work parameters are invalid" do
+      let(:work_params) {
+        {
+            work: {


Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

houndci-bot · 2018-07-07T07:01:27Z

    end

+    context "when work parameters are invalid" do
+      let(:work_params) {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2018-07-07T07:01:27Z

+    it "should throw error when there are invalid tags and trying to preview" do
+      allow_any_instance_of(Work).to receive(:invalid_tags).and_return([create(:unsorted_tag)])
+
+      expect {patch :update_tags, params: { id: work, preview_button: true } }.to raise_error UncaughtThrowError


Layout/SpaceInsideBlockBraces: Space missing inside {.

houndci-bot · 2018-07-07T07:01:28Z

+        end
+
+        xit "should show results" do
+          get :collected, params: { user_id: collected_user.login, work_search: { query: "fandom_ids:#{collected_fandom.id}" }}


Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2018-07-07T07:01:28Z

-    let(:update_work) {
+    let!(:update_user) { create(:user) }
+    let!(:update_chapter) { create(:chapter) }
+    let!(:update_work) {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2018-07-07T07:01:28Z

+
+  context "destroy" do
+    let(:user) { create(:user) }
+    let!(:work) {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2018-07-07T07:01:28Z


+  describe "edit" do
+    let(:user) { create(:user) }
+    let(:work) {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

hatal175 · 2018-07-07T10:20:16Z

Well, I removed the changes I made beyond adding tests and pending tests. I've sent a mail about the things I found.
I'd still like to reexamine the preview mode lines and another line dealing with collections before I consider this ready for review

hatal175 added 3 commits November 13, 2017 07:38

AO3-4855 Started working on extending works controller tests

0920df1

Also implemented show multiple for pseuds

AO3-4862 Extended work controller test coverage

d24e590

- Added edit multiple works for pseud - Removed several dead code paths

AO3-4862 Fix rspec tests

2706fb6

houndci-bot reviewed Nov 17, 2017

View reviewed changes

sarken added the Awaiting Review label Nov 17, 2017

sarken added Reviewed: Action Needed and removed Awaiting Review labels Jun 29, 2018

hatal175 added 2 commits July 5, 2018 20:50

AO3-4862 Merge remote-tracking branch 'upstream/master' into AO4-4862

bff6b8a

AO3-4862 Remove fixes to be done later in other pull requests

047287c

houndci-bot reviewed Jul 7, 2018

View reviewed changes

cesy mentioned this pull request Aug 19, 2020

AO3-4862 Extending work controller test coverage #3888

Closed

hatal175 closed this Apr 15, 2022

Bilka2 mentioned this pull request Aug 1, 2026

AO3-4862 Extend works controller test coverage #5959

Open

Uh oh!

Conversation

hatal175 commented Nov 17, 2017

Issue

Purpose

Testing

Credit

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarken commented Jun 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hatal175 commented Jul 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants