AO3-4862 Extend works controller test coverage - #5959
Open
Bilka2 wants to merge 5 commits into
Open
Conversation
Bilka2
commented
Aug 1, 2026
| end | ||
| end | ||
|
|
||
| describe "GET #preview_tags" do |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure about adding this - this is never linked anywhere on the site, the action is only used for render inside the controller. But it does indeed exist and is indeed accessible to users, so I guess we should at least make sure it doesn't error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-4862
Purpose
Brings the test coverage of the works controller to 100% by adding a few tests and removing one inaccessible bit of code.
Testing Instructions
After the automatic tests have run after merging, https://app.codecov.io/gh/otwcode/otwarchive/blob/master/app%2Fcontrollers%2Fworks_controller.rb should show 100% for the file.
References
Adopts #3888
PR limit does not apply to volunteers with write access to the repository.
Credit
Tal Hayon (for code at #3165)
cesy (previous code)
sarken (previous review)
ticking instant (previous review)
Bilka