Skip to content

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Oct 22, 2024

What: towards #7287

Additional issues:

@tlabaj tlabaj requested a review from nicolethoen October 22, 2024 19:49
@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 22, 2024

@tlabaj
Copy link
Contributor Author

tlabaj commented Oct 22, 2024

@jonkoops @nicolethoen I do not see the same styling issues that were seen in v5 when Jon tried to upgrade dnd-kit before in this PR. If this looks good, I think it is safe to hold off on getting this in until after v6 is live.

@tlabaj tlabaj marked this pull request as ready for review October 30, 2024 13:50
@tlabaj tlabaj requested a review from kmcfaul October 30, 2024 14:38
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the style issue from the previous PR was actually unrelated to the dependency bump (was fixed in #10612)

@dlabaj dlabaj merged commit 5e618d6 into patternfly:main Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants