Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eido/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.2.5"
__version__ = "0.2.6"
5 changes: 5 additions & 0 deletions eido/output_formatters.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ def _convert_sample_to_row(
else:
value = sample.get(attribute)

if isinstance(value, float) and value != value:
# pandas (>=3.0) yields float('nan') instead of None for missing
# values when a Sample's attributes originate from a DataFrame
value = None

sample_row.append(value or "")

return ",".join(sample_row)
Expand Down
2 changes: 1 addition & 1 deletion requirements/requirements-all.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
importlib-metadata; python_version < '3.10'
jsonschema>=3.0.1
logmuse>=0.2.5
pandas<3.0.0
pandas
peppy>=0.40.7
ubiquerg>=0.5.2
28 changes: 28 additions & 0 deletions tests/test_conversions.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
pep_conversion_plugins,
convert_project,
)
from eido.output_formatters import MultilineOutputFormatter
import peppy


Expand Down Expand Up @@ -104,3 +105,30 @@ def test_multiple_subsamples(self, test_multiple_subs):
"yaml-samples",
)
assert isinstance(conversion["samples"], str)


class TestMultilineOutputFormatterMissingValues:
"""
Under pandas >=3.0 a missing attribute reaches the formatter as float('nan')
rather than as an empty string, which used to raise TypeError from the join.
"""

def test_missing_attribute_becomes_empty_field(self):
sample = peppy.Sample({"sample": "frog_1", "fasta": float("nan")})

assert MultilineOutputFormatter.format([sample]) == "sample,fasta\nfrog_1,\n"

def test_missing_subsample_attribute_becomes_empty_field(self):
# Merging a subsample table that lacks a column produces a list of nan
sample = peppy.Sample(
{
"sample": "frog_1",
"fasta": [float("nan"), float("nan")],
"subsample_name": ["0", "1"],
}
)

assert (
MultilineOutputFormatter.format([sample])
== "sample,fasta\nfrog_1,\nfrog_1,\n"
)
Loading