Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13364 beanstalk removal #13850

Merged
merged 18 commits into from
Feb 23, 2019
Merged

T13364 beanstalk removal #13850

merged 18 commits into from
Feb 23, 2019

Conversation

niden
Copy link
Member

@niden niden commented Feb 22, 2019

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Removed Beanstalkd/Queue from Phalcon (new implementation will come next version)

Thanks

* upstream/4.0.x:
  [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x:
  [#13488] - Removed commas that crept in the .env file
  [#13488] - Minor corection to debug; Added funcitonality for getting filtered vars; Added tests
  [#13488] - Initial changes for the feature; adding methods
* upstream/4.0.x:
  Updated changelog
  Updated CFLAG default build param
  keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?)
  move formatter into setter
  give up on `camelize`, use a new approach
  unit tests
  Camel-case the action name (before call in handler)
  Correct pull request template
  Fix .editorconfig
  Amended .gitignore
  Bump version
  Fixed preparing release on AppVeyor
  Update change log
  Regenerated build
  Regenerated ext
  Updating the changelog
* upstream/4.0.x:
  Updated the changelog
  [#13808] - Updating ext folder
  [#13808] - Adjusting tests
  [#13808] - Renaming ACL elements
* upstream/4.0.x:
  Update CHANGELOG-4.0.md
  Updated changelog
  Added geSetMetaData test Modified some unit tests to use metaData
  Modified existing tests to work with the additional MetaData
  Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel()
  Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly
  Corrected typo
* upstream/4.0.x:
  [#2182] - Updated the changelog and PR template
  [#2182] - Added before/after compile events for Volt
  [#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [#13819] - Updated the changelog
  [#13819] - Removing css/js optimizers from the config
  [#13819] - Updating ext/
  [#13819] - Removed minifiers
  [#13819] - Marked tests as skipped
* upstream/4.0.x:
  Allow Config::merge to accept a basic array. (#13830)
* upstream/4.0.x:
  T13336 find first null (#13826)
  renamed phalcon\mvc\url to phalcon\url (#13831)
* upstream/4.0.x:
  Install MySQL 5.7 on Travis CI [skip appveyor] (#13835)
* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (#13836)
  T13687 debug hide vars (#13833)
@niden niden added New Feature Request breaks bc Functionality that breaks Backwards Compatibility labels Feb 22, 2019
sergeyklay
sergeyklay previously approved these changes Feb 23, 2019
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update change log

@dschissler

This comment was marked as abuse.

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (4.0.x@371b25d). Click here to learn what that means.
The diff coverage is 79.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##             4.0.x   #13850   +/-   ##
========================================
  Coverage         ?   66.82%           
========================================
  Files            ?      448           
  Lines            ?    88915           
  Branches         ?        0           
========================================
  Hits             ?    59420           
  Misses           ?    29495           
  Partials         ?        0
Impacted Files Coverage Δ
ext/phalcon/http/responseinterface.zep.c 100% <ø> (ø)
ext/phalcon.c 97.51% <ø> (ø)
ext/phalcon/0__closure.zep.c 25% <0%> (ø)
ext/phalcon/11__closure.zep.c 25% <0%> (ø)
ext/phalcon/12__closure.zep.c 25% <0%> (ø)
ext/phalcon/10__closure.zep.c 25% <0%> (ø)
ext/phalcon/23__closure.zep.c 25% <0%> (ø)
ext/phalcon/translate/adapter/csv.zep.c 79.59% <100%> (ø)
ext/phalcon/validation/validator/uniqueness.zep.c 71.12% <100%> (ø)
ext/phalcon/validation/validator/date.zep.c 100% <100%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371b25d...8efc34d. Read the comment docs.

…beanstalk-removal

* upstream/4.0.x:
  T13844 mcall undefined errors (#13849)
@niden niden merged commit da2b94a into phalcon:4.0.x Feb 23, 2019
@niden niden deleted the T13364-beanstalk-removal branch March 13, 2019 20:21
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants