Skip to content

CP-17536 - fixing the options for checkbox/radio; removing dead code - #17537

Merged
niden merged 3 commits into
5.0.xfrom
CP-17536-forms-loader-options
Aug 29, 2026
Merged

CP-17536 - fixing the options for checkbox/radio; removing dead code#17537
niden merged 3 commits into
5.0.xfrom
CP-17536-forms-loader-options

Conversation

@niden

@niden niden commented Aug 29, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

  • Phalcon\Forms\Element\CheckGroup and RadioGroup storing their choices in the property Phalcon\Forms\Element\AbstractElement uses for user options, so setUserOption() added a choice and setOptions() removed every user option.
  • Phalcon\Forms\Element\Select::addOption() writing with an offset into an object or null options value; the write now happens only when the options value is an array (null becomes an empty array).

Thanks

@niden
niden requested a review from Jeckerson August 29, 2026 00:05
@niden niden self-assigned this Aug 29, 2026
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium labels Aug 29, 2026
@niden
niden merged commit dd3c0ee into 5.0.x Aug 29, 2026
192 of 202 checks passed
@niden
niden deleted the CP-17536-forms-loader-options branch August 29, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant