Skip to content

Conversation

@Jeroeny
Copy link
Contributor

@Jeroeny Jeroeny commented Nov 23, 2019

#SymfonyHackday

@Steveb-p
Copy link
Contributor

We should also add 5.0 to travis matrix.

@Jeroeny
Copy link
Contributor Author

Jeroeny commented Nov 23, 2019

We should also add 5.0 to travis matrix.

Added, let me know what you think 👍.

@Steveb-p
Copy link
Contributor

Steveb-p commented Nov 23, 2019

The are some conflicts with dev dependencies.

There should also be an expected test failure due to #984 not yet resolved :)

I’ll have a look once I’m in front of a pc.

@Jeroeny
Copy link
Contributor Author

Jeroeny commented Nov 24, 2019

Indeed, it's this package: voryx/Thruway#329, for which I've made a PR.
Also PhpStan, but it looks like they already have a version WIP that removes a lot of dependencies, including symfony.

Edit: I was looking at phpstan/phpstan, but the development actually happens in phpstan-src. Which has 0.12 WIP that doesn't depend on symfony anymore.

@kuraobi
Copy link
Contributor

kuraobi commented Dec 1, 2019

@Jeroeny your PR was not sufficient so I did another one: voryx/Thruway#331 , but the maintainer says he prefers to remove the dependency to Symfony. So waiting for him to fork https://github.com/symfony/event-dispatcher and use that fork instead.

@kuraobi kuraobi mentioned this pull request Dec 12, 2019
@kuraobi
Copy link
Contributor

kuraobi commented Dec 12, 2019

As there was no activity on voryx/Thruway#331 , I found another solution in #997 . Actually had a lot more to fix then, I detailed it in my PR.

@makasim makasim merged commit 3943c7e into php-enqueue:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants