Skip to content

Comments

Filling existing fields form while editing a view#14941

Merged
williamdes merged 2 commits intophpmyadmin:QA_4_8from
bahl24:fix#14926
Mar 25, 2019
Merged

Filling existing fields form while editing a view#14941
williamdes merged 2 commits intophpmyadmin:QA_4_8from
bahl24:fix#14926

Conversation

@bahl24
Copy link
Contributor

@bahl24 bahl24 commented Feb 8, 2019

Description

Fills form based on GET params available

Fixes #14926 #14916 (comment)
Testing-
Go to structure tab of a view and click on edit view.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@bahl24
Copy link
Contributor Author

bahl24 commented Feb 8, 2019

@ibennetch @williamdes Kindly test the pr by Testing-
Go to structure tab of a view and click on edit view.
This is in response to #14916 (comment)
Will add same functionality to #14926 shortly

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #14941 into QA_4_8 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             QA_4_8   #14941      +/-   ##
============================================
- Coverage     55.69%   55.68%   -0.02%     
- Complexity    14443    14444       +1     
============================================
  Files           494      494              
  Lines         70859    70873      +14     
============================================
  Hits          39467    39467              
- Misses        31392    31406      +14

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (QA_4_8@537a007). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             QA_4_8   #14941   +/-   ##
=========================================
  Coverage          ?   52.99%           
  Complexity        ?    14454           
=========================================
  Files             ?      494           
  Lines             ?    64113           
  Branches          ?        0           
=========================================
  Hits              ?    33977           
  Misses            ?    30136           
  Partials          ?        0

@bahl24
Copy link
Contributor Author

bahl24 commented Feb 8, 2019

@ibennetch @williamdes Both the issues #14926 #14916 have been fixed, kindly check and test.

@bahl24
Copy link
Contributor Author

bahl24 commented Feb 24, 2019

@williamdes @ibennetch Kindly take a look at it

@williamdes williamdes self-requested a review February 24, 2019 07:50
@bahl24
Copy link
Contributor Author

bahl24 commented Feb 26, 2019

@ibennetch What do you think?

@williamdes
Copy link
Member

The code looks really good, when I have tested it I will merge this PR ;)

@bahl24
Copy link
Contributor Author

bahl24 commented Mar 15, 2019

The code looks really good, when I have tested it I will merge this PR ;)

I am glad you liked it, while testing kindly check why codecov test is failing. Or maybe I should push recent changes to the branch.

@bahl24
Copy link
Contributor Author

bahl24 commented Mar 25, 2019

@MauricioFauth @williamdes Did you test this PR?

Fix: phpmyadmin#14926
See: phpmyadmin#14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, thank you @bahl24 for the contribution !
I have done some minor changes and rebased the branch before merge

@williamdes williamdes added this to the 4.8.6 milestone Mar 25, 2019
@williamdes williamdes self-assigned this Mar 25, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 6de38a0 into phpmyadmin:QA_4_8 Mar 25, 2019
@bahl24 bahl24 deleted the fix#14926 branch March 25, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants