Filling existing fields form while editing a view#14941
Filling existing fields form while editing a view#14941williamdes merged 2 commits intophpmyadmin:QA_4_8from
Conversation
|
@ibennetch @williamdes Kindly test the pr by Testing- |
Codecov Report
@@ Coverage Diff @@
## QA_4_8 #14941 +/- ##
============================================
- Coverage 55.69% 55.68% -0.02%
- Complexity 14443 14444 +1
============================================
Files 494 494
Lines 70859 70873 +14
============================================
Hits 39467 39467
- Misses 31392 31406 +14 |
Codecov Report
@@ Coverage Diff @@
## QA_4_8 #14941 +/- ##
=========================================
Coverage ? 52.99%
Complexity ? 14454
=========================================
Files ? 494
Lines ? 64113
Branches ? 0
=========================================
Hits ? 33977
Misses ? 30136
Partials ? 0 |
|
@ibennetch @williamdes Both the issues #14926 #14916 have been fixed, kindly check and test. |
|
@williamdes @ibennetch Kindly take a look at it |
|
@ibennetch What do you think? |
|
The code looks really good, when I have tested it I will merge this PR ;) |
I am glad you liked it, while testing kindly check why codecov test is failing. Or maybe I should push recent changes to the branch. |
|
@MauricioFauth @williamdes Did you test this PR? |
Fix: phpmyadmin#14926 See: phpmyadmin#14916 Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com> Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes
left a comment
There was a problem hiding this comment.
Merged, thank you @bahl24 for the contribution !
I have done some minor changes and rebased the branch before merge
Signed-off-by: William Desportes <williamdes@wdes.fr>
Description
Fills form based on GET params available
Fixes #14926 #14916 (comment)
Testing-
Go to structure tab of a view and click on edit view.
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.