fix(threads): keep completed requests closed across clients

[t3dotgg]

Web and mobile each had their own reducer for pending approvals and questions. The mobile copy lacked two of the stale-request failure fragments web matches and did not map dynamic_tool_call approvals, so a request could stay open on one client after another client answered it.

The fix moves the reducer into packages/client-runtime as derivePendingRequests. It keys on request ID, treats a resolved or stale-failed request as final even when activities arrive out of order, and is used by web, desktop, and mobile. Tests for the reducer move with it.

Removed from the original version: the typed reason field on respond.failed payloads, the ProviderAdapterRequestNotFoundError across the six adapters, the decider invariant, the projector retention change, and the snapshot query changes. Those touched server orchestration and contracts for a client-side bug, and the client already closes requests from the existing failure text. The server is unchanged.

Reworked by Claude Fable 5.1 in Claude Code.

Note

Keep completed requests closed across clients with shared derivePendingRequests reducer

• Moves pending approval and user-input derivation out of session-logic.ts and threadActivity.ts into a single shared reducer in pendingRequests.ts, exported via the new ./pending-requests subpath.
• The reducer tracks closed request-ID sets so that a reordered or replayed request activity cannot reopen a request after its terminal event; non-stale response failures no longer close a request.
• Adds shared parseQuestions and isStaleRequestFailure utilities; malformed question/option entries are discarded and native answer keys are preserved without trimming.
• Moves platform-local test suites into pendingRequests.test.ts with added parameterized coverage for terminal-event ordering.
• Behavioral Change: web and mobile hooks now call derivePendingRequests once instead of separate approval/user-input derivation functions; consumers must destructure { approvals, userInputs } from the new result shape.

^{Macroscope summarized 7741079.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.6 KiB	+23 B (+0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+5 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.6 KiB	+18 B (+0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	57.1 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.6 KiB	+35 B (+0.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−1 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+36 B (+0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	+44 B (+0.1%)	66.4 KiB	✅
Claude	Live turn messages	8	9	+1 (+12.5%)	21	✅

Baseline: eb8ed80 · PR result: 7741079 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 7741079

Macroscope's review found this PR approvable — This is a focused fix to pending approval and user-input lifecycle handling across web and mobile, with the shared reducer and its ordering behavior covered by dedicated tests. The change preserves existing interfaces and data while avoiding schema, deployment, security, billing, and configuration impact.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.