refactor(server): share Claude result status and error mapping

[t3dotgg]

Claude turn status and error text use separate lists of terminal failure reasons. A new reason can update one list and leave the other wrong.

Use one result mapper for both values. Keep existing error priority, success-tagged failures, overloads, interruption, cancellation, and unknown CLI reasons.

All 95 Claude adapter tests passed, including two new unknown-reason cases. Server typecheck and scoped lint passed. Independent source review found no behavior changes.

Created in Codex.

Note

Unify Claude result status and error mapping in resultOutcome

• Replaces separate result-level status and user-facing error helpers with a single resultOutcome helper in ClaudeAdapter.ts that derives turn status and error text together
• Removes the FAILED_TERMINAL_REASONS constant; its reason list now lives in the terminalResultError switch
• Recognized structured terminal reasons mark the turn as failed regardless of result subtype, while success-tagged results with unknown terminal reasons stay completed
• Adds a parameterized test covering success and error subtypes with unknown terminal reasons in ClaudeAdapter.test.ts
• Risk: handleResultMessage now routes all result outcomes through resultOutcome; any terminal reason not in the terminalResultError switch will no longer be treated as a failure on success-tagged results

^{Macroscope summarized 489846c.}

[macroscopeapp]

Approvability

Verdict: Approved at 329fb04

Macroscope's review found this PR approvable — This is a small, self-contained refactor that unifies existing Claude result status and error mapping without changing the established outcomes. The added tests cover forward compatibility with unknown terminal reasons, and no product defaults or static-analysis suppressions are affected.

No code changes detected at 489846c. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.6 KiB	+65 B (+0.5%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.6 KiB	+70 B (+1.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.1 KiB	+88 B (+0.2%)	66.4 KiB	✅
Codex	Live turn messages	8	10	+2 (+25.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.5 KiB	−42 B (−0.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−1 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.5 KiB	−41 B (−0.6%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	57.8 KiB	−88 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	8	−2 (−20.0%)	21	✅

Baseline: 7544d3d · PR result: 489846c · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.