Skip to content

fix(marketing): present the Git workflow as an illustration - #10130

Merged
juliusmarminge merged 3 commits into
pingdotgg:mainfrom
saphid:fix/quick-e1011-019-20260905
Sep 6, 2026
Merged

fix(marketing): present the Git workflow as an illustration#10130
juliusmarminge merged 3 commits into
pingdotgg:mainfrom
saphid:fix/quick-e1011-019-20260905

Conversation

@saphid

@saphid saphid commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

What Changed

The homepage Git illustration included three focusable buttons that do nothing. Render them as decorative spans and expose the workflow as one explicitly labelled illustration, preserving its appearance.

Verification

Refreshed against upstream main 761d4bac1c238ea7af4dd36b56719ad5e30771c3. Fresh targeted lint, marketing Astro check (18 files, zero diagnostics), and git diff --check origin/main...HEAD pass. The PR component file is byte-for-byte unchanged from the previously captured candidate, so the existing evidence still demonstrates this contribution; it has not been relabeled as a fresh capture. Refresh performed by GPT-6 Astra in the Codex harness. Fresh independent Claude review is unavailable: claude auth status reports signed out.

Astro check passes for 18 files with zero diagnostics; targeted lint and diff check pass. Browser accessibility tree exposes one illustrative image description, and the illustration has zero focusable controls.

Marketing site only. No Git operations are executed by this illustration.

UI Changes

Before: upstream 6270a6f88; after: 9c61c464e. Same homepage section, viewport and scroll position; appearance is preserved while semantics change.

Before

Before: marketing change

After

After: marketing change

The change is nonvisual. Screenshots provide control context only; verification relies on the accessibility-tree observations described above. No animated GIF is included because unchanged UI footage does not demonstrate the semantic change.

Checklist

  • Small, focused change
  • Problem and verification explained
  • Before/after UI evidence included

Implemented by GPT-6 Astra medium task workers, reviewed and verified by GPT-6 Astra in the T3 Code Codex harness. Direct cross-provider review attempted with claude --model claude-opus-5 --effort high --permission-mode plan --tools Read,Glob,Grep --output-format json -p …; exit 1 because OAuth expired. No Claude model ran.

Note

Convert Git workflow buttons to non-interactive illustration in marketing page

Updates index.astro so the Git workflow visual is exposed to assistive tech as a single labeled image instead of a set of controls. Replaces the three nested button elements with span elements that keep their text and icons, and adds an image role with an accessible label to the container.

  • Sets pointer-events: none on the button-styled spans and normal line-height on affected labels so the illustration renders without interaction behavior.
  • Risk: assistive tech users no longer see individual button semantics for View diff, Open pull request, or Commit & push in this illustration.

Macroscope summarized 8fbb2ef.

Current-base verification

Updated to upstream main b2e15185aee22bfdee78806f2734b0a4de9c2c77 at 8fbb2efb0e427d02d9f9bcdacef97bc52c5cf2e1. All 3 applicable focused verification commands passed. Earlier runtime observations and media retain their stated revisions and limitations; these fresh runs do not constitute new client recordings. Fresh independent Claude review is unavailable because its OAuth credentials have expired. Refreshed by GPT-6 Astra in the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 9c61c46

Macroscope's review found this PR approvable — This single-file marketing change preserves the Git workflow illustration while removing inert focusable controls and exposing it as one labeled image. Its runtime impact is limited to page semantics, pointer behavior, and styling, with no product-default, application workflow, or infrastructure changes.

You can add or adjust custom eligibility rules. Learn more.

@t3-code t3-code Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed diff and relevant surrounding code at 8fbb2efb0e427d02d9f9bcdacef97bc52c5cf2e1. no blocking findings.

the decorative controls become non-focusable spans inside a named illustration; the adjacent explanatory copy remains outside that image role. no code changes needed. visual rendering was not rerun locally.

ci snapshot: no failing or pending checks; some checks are skipped. this is a comment review, not an approval or merge.

@juliusmarminge
juliusmarminge merged commit e5d086c into pingdotgg:main Sep 6, 2026
21 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 6, 2026
## What's Changed
* feat(usage): pool subscription limits per provider across accounts and environments by @juliusmarminge in pingdotgg/t3code#10300
* chore(web): remove usage limits demo fixtures by @juliusmarminge in pingdotgg/t3code#10330
* fix(web): expose error disclosure state by @saphid in pingdotgg/t3code#10125
* fix(web): name the editor picker accurately by @saphid in pingdotgg/t3code#10124
* fix(web): make task row states readable by @saphid in pingdotgg/t3code#10128
* fix(web): explain hosted connection prerequisites by @saphid in pingdotgg/t3code#10129
* fix(web): name combobox chip removal targets by @saphid in pingdotgg/t3code#10127
* fix(marketing): present the Git workflow as an illustration by @saphid in pingdotgg/t3code#10130
* feat(mobile): pool usage limits across selected environments by @juliusmarminge in pingdotgg/t3code#10334
* fix(release): space automatic nightlies at least six hours apart by @t3dotgg in pingdotgg/t3code#10272
* refactor(web): share bulk thread deletion between sidebars by @t3dotgg in pingdotgg/t3code#10106
* refactor(client): share tool outcome rules by @t3dotgg in pingdotgg/t3code#10122
* refactor(server): share Claude result status and error mapping by @t3dotgg in pingdotgg/t3code#10296
* fix(server): settle inactive threads without a PR lookup by @t3dotgg in pingdotgg/t3code#10103
* fix(ssh): report remote stop failures without losing ownership by @t3dotgg in pingdotgg/t3code#10105
* perf(server): stop scanning old OpenCode parts by @t3dotgg in pingdotgg/t3code#10116
* perf(server): avoid full thread reads on turn start by @t3dotgg in pingdotgg/t3code#10108
* perf(web): skip checkpoint map rebuilds while streaming by @t3dotgg in pingdotgg/t3code#10118
* perf(server): skip plan bodies in thread summaries by @t3dotgg in pingdotgg/t3code#10341
* fix(server): skip disabled provider instances for text generation fallback by @t3dotgg in pingdotgg/t3code#10346
* fix(server): capture checkpoints before refreshing PR status by @t3dotgg in pingdotgg/t3code#10347
* fix(web): keep manual panel choices during a turn by @t3dotgg in pingdotgg/t3code#10113
* fix(threads): keep completed requests closed across clients by @t3dotgg in pingdotgg/t3code#10123
* perf(server): finish runtime messages without full thread reads by @t3dotgg in pingdotgg/t3code#10120
* refactor(server): let adapters declare context compaction by @t3dotgg in pingdotgg/t3code#10112
* fix(server): link thread PRs without an open client by @t3dotgg in pingdotgg/t3code#10101


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1293...v0.0.39-nightly.20260906.1303

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants