ci: reject unused SSH exports with Knip - #10145
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small CI-only change that extends the existing Knip export check to the SSH workspace, with no product runtime, default, schema, or deployment impact. It broadens static-analysis coverage rather than suppressing diagnostics. Notes:
You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * test(web): drop provider banner styling assertions by @juliusmarminge in pingdotgg/t3code#10148 * refactor(client-runtime): remove unused relay token waiter by @juliusmarminge in pingdotgg/t3code#10151 * test(web): drop sidebar artwork styling snapshots by @juliusmarminge in pingdotgg/t3code#10152 * refactor(ssh): keep package internals private by @juliusmarminge in pingdotgg/t3code#10144 * ci: reject unused SSH exports with Knip by @juliusmarminge in pingdotgg/t3code#10145 * refactor(acp): keep protocol implementation exports private by @juliusmarminge in pingdotgg/t3code#10165 * fix(shared): validate cloudflared with the version subcommand by @maria-rcks in pingdotgg/t3code#9880 * fix(desktop): separate LAN and Tailscale pairing endpoints by @maria-rcks in pingdotgg/t3code#9882 * fix(server): install pinned runtime when pnpm node lacks npm by @maria-rcks in pingdotgg/t3code#9923 * fix(web): hide sidebar search shortcut on mobile by @maria-rcks in pingdotgg/t3code#9932 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1288...v0.0.39-nightly.20260905.1289 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1289
SSH's unused exports are now cleaned up in the preceding layer. Add packages/ssh to the existing Knip export check so CI rejects new unused SSH exports and types.
The existing files/dependencies check and other workspace checks stay enabled. No dependencies, suppressions, or entry-point exceptions are added.
Verification: vp run knip:check passes with SSH included. The preceding layer resolves the 17 SSH findings that would otherwise fail this gate. No runtime or UI changes.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Note
Add
packages/sshtoknip:checkworkspace listExtends the Knip export analysis to cover the
packages/sshworkspace so unused SSH exports are caught in CI.Macroscope summarized 2cf0792.