Skip to content

ci: reject unused SSH exports with Knip - #10145

Merged
juliusmarminge merged 1 commit into
cleanup-ssh/private-exportsfrom
cleanup-ssh/knip-gate
Sep 5, 2026
Merged

ci: reject unused SSH exports with Knip#10145
juliusmarminge merged 1 commit into
cleanup-ssh/private-exportsfrom
cleanup-ssh/knip-gate

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 5, 2026

Copy link
Copy Markdown
Member

SSH's unused exports are now cleaned up in the preceding layer. Add packages/ssh to the existing Knip export check so CI rejects new unused SSH exports and types.

The existing files/dependencies check and other workspace checks stay enabled. No dependencies, suppressions, or entry-point exceptions are added.

Verification: vp run knip:check passes with SSH included. The preceding layer resolves the 17 SSH findings that would otherwise fail this gate. No runtime or UI changes.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Note

Add packages/ssh to knip:check workspace list

Extends the Knip export analysis to cover the packages/ssh workspace so unused SSH exports are caught in CI.

Macroscope summarized 2cf0792.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.6 KiB 7.8 KiB
Codex Live turn WebSocket decoded 57.1 KiB 66.4 KiB
Codex Live turn messages 10 21
Claude Total thread wire 13.6 KiB 15.1 KiB
Claude Thread snapshot wire 7.0 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 7.8 KiB
Claude Live turn WebSocket decoded 57.9 KiB 66.4 KiB
Claude Live turn messages 10 21

Baseline: unavailable · PR result: 2cf0792 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2cf0792

Macroscope's review found this PR approvable — This is a small CI-only change that extends the existing Knip export check to the SSH workspace, with no product runtime, default, schema, or deployment impact. It broadens static-analysis coverage rather than suppressing diagnostics.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 62ed748 into main Sep 5, 2026
20 checks passed
@juliusmarminge
juliusmarminge deleted the cleanup-ssh/knip-gate branch September 5, 2026 16:16
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 5, 2026
## What's Changed
* test(web): drop provider banner styling assertions by @juliusmarminge in pingdotgg/t3code#10148
* refactor(client-runtime): remove unused relay token waiter by @juliusmarminge in pingdotgg/t3code#10151
* test(web): drop sidebar artwork styling snapshots by @juliusmarminge in pingdotgg/t3code#10152
* refactor(ssh): keep package internals private by @juliusmarminge in pingdotgg/t3code#10144
* ci: reject unused SSH exports with Knip by @juliusmarminge in pingdotgg/t3code#10145
* refactor(acp): keep protocol implementation exports private by @juliusmarminge in pingdotgg/t3code#10165
* fix(shared): validate cloudflared with the version subcommand by @maria-rcks in pingdotgg/t3code#9880
* fix(desktop): separate LAN and Tailscale pairing endpoints by @maria-rcks in pingdotgg/t3code#9882
* fix(server): install pinned runtime when pnpm node lacks npm by @maria-rcks in pingdotgg/t3code#9923
* fix(web): hide sidebar search shortcut on mobile by @maria-rcks in pingdotgg/t3code#9932


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1288...v0.0.39-nightly.20260905.1289

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant