Skip to content

refactor(client-runtime): remove unused relay token waiter - #10151

Merged
juliusmarminge merged 1 commit into
mainfrom
cleanup-wave4/unused-relay-token-wait
Sep 5, 2026
Merged

refactor(client-runtime): remove unused relay token waiter#10151
juliusmarminge merged 1 commit into
mainfrom
cleanup-wave4/unused-relay-token-wait

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

waitForManagedRelayClerkToken has no production callers. Its only caller is a direct unit test. Remove that unused subscription/wait implementation and its test.

The live session token reader remains in place for deregistration and relay queries. Keep the tests for account changes, concurrent token-read deduplication, expiry, replacing token readers, pending reads, and query behavior. Repository-wide references, including the relay barrel's consumers in web and mobile, do not use this helper.

Verification: all 13 remaining managedRelayState tests pass, along with targeted lint and the client-runtime typecheck. Typecheck reports two existing suggestions in unrelated files, no errors. No UI changes.

Model: gpt-6 astra. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 5, 2026
@juliusmarminge
juliusmarminge merged commit 29c3a54 into main Sep 5, 2026
20 checks passed
@juliusmarminge
juliusmarminge deleted the cleanup-wave4/unused-relay-token-wait branch September 5, 2026 15:43
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB +7 B (+0.1%) 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.0 KiB +1 B (+0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB +6 B (+0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 8 8 0 (0.0%) 21
Claude Total thread wire 13.6 KiB 13.6 KiB +17 B (+0.1%) 15.1 KiB
Claude Thread snapshot wire 7.0 KiB 7.0 KiB +2 B (+0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB +15 B (+0.2%) 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 57.8 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 9 9 0 (0.0%) 21

Baseline: 761d4ba · PR result: 799c2bc · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 5, 2026
## What's Changed
* test(web): drop provider banner styling assertions by @juliusmarminge in pingdotgg/t3code#10148
* refactor(client-runtime): remove unused relay token waiter by @juliusmarminge in pingdotgg/t3code#10151
* test(web): drop sidebar artwork styling snapshots by @juliusmarminge in pingdotgg/t3code#10152
* refactor(ssh): keep package internals private by @juliusmarminge in pingdotgg/t3code#10144
* ci: reject unused SSH exports with Knip by @juliusmarminge in pingdotgg/t3code#10145
* refactor(acp): keep protocol implementation exports private by @juliusmarminge in pingdotgg/t3code#10165
* fix(shared): validate cloudflared with the version subcommand by @maria-rcks in pingdotgg/t3code#9880
* fix(desktop): separate LAN and Tailscale pairing endpoints by @maria-rcks in pingdotgg/t3code#9882
* fix(server): install pinned runtime when pnpm node lacks npm by @maria-rcks in pingdotgg/t3code#9923
* fix(web): hide sidebar search shortcut on mobile by @maria-rcks in pingdotgg/t3code#9932


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1288...v0.0.39-nightly.20260905.1289

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant