Skip to content

test(web): drop provider banner styling assertions - #10148

Merged
juliusmarminge merged 1 commit into
mainfrom
cleanup-wave4/provider-banner-tests
Sep 5, 2026
Merged

test(web): drop provider banner styling assertions#10148
juliusmarminge merged 1 commit into
mainfrom
cleanup-wave4/provider-banner-tests

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

The provider warning banner tests asserted literal positioning classes and a glass styling token. Those assertions cannot verify whether the banner is visually readable. Remove the styling-only test and positioning assertion.

Keep the auth-probe rules, installation and startup failures, dismissed-warning state, accessible dismiss labels and severity, and provider error messages. Production code is unchanged.

Verification: the focused ProviderStatusBanner suite passes, nine tests. No visual behavior changes.

Model: gpt-6 astra. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.6 KiB +89 B (+0.6%) 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.0 KiB +5 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 6.6 KiB +84 B (+1.3%) 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 57.1 KiB +88 B (+0.2%) 66.4 KiB
Codex Live turn messages 8 10 +2 (+25.0%) 21
Claude Total thread wire 13.6 KiB 13.5 KiB −25 B (−0.2%) 15.1 KiB
Claude Thread snapshot wire 7.0 KiB 7.0 KiB −5 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB −20 B (−0.3%) 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 57.8 KiB −44 B (−0.1%) 66.4 KiB
Claude Live turn messages 9 8 −1 (−11.1%) 21

Baseline: 761d4ba · PR result: 3fe8c84 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge merged commit 47e250a into main Sep 5, 2026
19 checks passed
@juliusmarminge
juliusmarminge deleted the cleanup-wave4/provider-banner-tests branch September 5, 2026 15:42
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 5, 2026
## What's Changed
* test(web): drop provider banner styling assertions by @juliusmarminge in pingdotgg/t3code#10148
* refactor(client-runtime): remove unused relay token waiter by @juliusmarminge in pingdotgg/t3code#10151
* test(web): drop sidebar artwork styling snapshots by @juliusmarminge in pingdotgg/t3code#10152
* refactor(ssh): keep package internals private by @juliusmarminge in pingdotgg/t3code#10144
* ci: reject unused SSH exports with Knip by @juliusmarminge in pingdotgg/t3code#10145
* refactor(acp): keep protocol implementation exports private by @juliusmarminge in pingdotgg/t3code#10165
* fix(shared): validate cloudflared with the version subcommand by @maria-rcks in pingdotgg/t3code#9880
* fix(desktop): separate LAN and Tailscale pairing endpoints by @maria-rcks in pingdotgg/t3code#9882
* fix(server): install pinned runtime when pnpm node lacks npm by @maria-rcks in pingdotgg/t3code#9923
* fix(web): hide sidebar search shortcut on mobile by @maria-rcks in pingdotgg/t3code#9932


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1288...v0.0.39-nightly.20260905.1289

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant