fix(web): enable restore defaults after theme mix changes

[Lucenx9]

Problem

Changing only the light or dark theme mix could leave the restore dirty-state memo stale because themeHalves was read but omitted from its dependency list. Restore defaults could therefore remain disabled and the restore action could return early.

Fix

Include themeHalves in the changedSettingLabels memo dependencies so theme-mix-only changes immediately update the restore state.

Verification

• Reproduced the missing dependency with a targeted react-hooks/exhaustive-deps check; the themeHalves diagnostic disappears after the fix
• node_modules/.bin/vp fmt --check apps/web/src/components/settings/SettingsPanels.tsx
• node_modules/.bin/vp lint --report-unused-disable-directives apps/web/src/components/settings/SettingsPanels.tsx
• node_modules/.bin/vp run --filter @t3tools/web typecheck
• git diff --check upstream/main...HEAD

Screenshots are not included because this changes state invalidation only, with no layout or styling changes.

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

Note

Fix 'Restore Defaults' detection to update when theme mix changes

Adds themeHalves to the useMemo dependency array in the useSettingsRestore hook in SettingsPanels.tsx, so changedSettingLabels recomputes immediately when the theme mix is modified. Previously, theme mix changes were not reflected in the restore defaults check or confirmation dialog.

^{Macroscope summarized b8dab78.}

---

Note

Low Risk
Single React hook dependency fix in settings restore state; no auth, data, or API behavior changes.

Overview
Restore defaults now reacts when only the light/dark theme mix changes.

useSettingsRestore already treated a non-null themeHalves as dirty and listed Theme mix in changedSettingLabels, but the useMemo for that list omitted themeHalves from its dependency array. After a mix-only edit, the memo could stay stale so restore stayed disabled and restoreDefaults could no-op on an empty label list.

The fix adds themeHalves to that dependency array so mix-only changes immediately refresh restore UI and confirmation copy.

^{Reviewed by Cursor Bugbot for commit b8dab78. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 11b6ac8c-06cd-4a7f-b0c2-82d0e14c69d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved b8dab78

This is a straightforward bug fix adding a missing React useMemo dependency. The themeHalves variable was used in the computation but not listed as a dependency, preventing the "restore defaults" feature from detecting theme mix changes.

^{You can customize Macroscope's approvability policy. Learn more.}