Skip to content

fix(web): correct model picker trigger padding - #5935

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
Chrono-byte:fix/model-picker-trigger-padding
Aug 10, 2026
Merged

fix(web): correct model picker trigger padding#5935
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
Chrono-byte:fix/model-picker-trigger-padding

Conversation

@Chrono-byte

@Chrono-byte Chrono-byte commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

The model picker trigger removed only its inline-start padding, which left the provider logo nearly touching the pressed-state edge while the chevron retained its end spacing.

This removes the ps-0 override while preserving the existing one-pixel optical offset. The trigger now inherits the shared ComposerControl padding on both sides.

Before / after verification

State Start padding End padding
Before 0px 10px
After 10px 10px

Measured in T3 Code Dev at a 1280x800 viewport.

Tests

  • vp lint apps/web/src/components/chat/ChatComposer.tsx --report-unused-disable-directives
  • vp run --filter @t3tools/web typecheck
  • vp test run src/components/chat/modelPickerSearch.test.ts src/components/chat/modelPickerKeys.test.ts --project unit (9 tests)

pre fix:
image

post fix:
image


Note

Cursor Bugbot is generating a summary for commit c5cd136. Configure here.

Note

Remove ps-0 padding from ProviderModelPicker trigger in ChatComposer

Removes the ps-0 class from the triggerClassName prop passed to ProviderModelPicker in ChatComposer.tsx, correcting the start-padding on the model picker trigger element.

Macroscope summarized c5cd136.

Copilot AI lite review requested due to automatic review settings August 10, 2026 01:53
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b164aed-ef7d-4227-ae68-080e74cac230

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the chat composer’s model picker trigger styling so it uses the shared ComposerControl padding consistently on both inline sides, fixing the asymmetry where the provider icon could appear too close to the pressed-state edge.

Changes:

  • Removes the ps-0 override from the ProviderModelPicker trigger in ChatComposer, keeping the existing -ms-px optical offset.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved c5cd136

Single-line CSS class change removing padding from a UI trigger element. Purely visual adjustment with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit cbd55d6 into pingdotgg:main Aug 10, 2026
17 checks passed
@Chrono-byte
Chrono-byte deleted the fix/model-picker-trigger-padding branch August 10, 2026 02:37
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 10, 2026
## What's Changed
* Move project settings to contextual project routes by @juliusmarminge in pingdotgg/t3code#5923
* Retain thread sidebar data when navigating to /settings so back navigation is instant by @juliusmarminge in pingdotgg/t3code#5930
* Automate production mobile EAS releases by @juliusmarminge in pingdotgg/t3code#5609
* Add settings and usage breadcrumbs by @juliusmarminge in pingdotgg/t3code#5929
* fix(web): correct model picker trigger padding by @Chrono-byte in pingdotgg/t3code#5935
* fix(web): show worktree icon in sidebar v2 by @tris203 in pingdotgg/t3code#5909
* fix(web): enable restore defaults after theme mix changes by @Lucenx9 in pingdotgg/t3code#5928
* fix(web): trait menu closes after you pick a level by @t3dotgg in pingdotgg/t3code#5879
* fix(web): align project name with headline by @carterwsmith in pingdotgg/t3code#5864
* fix(web): update pills use readable theme foregrounds by @chrisdeeming in pingdotgg/t3code#5938

## New Contributors
* @carterwsmith made their first contribution in pingdotgg/t3code#5864

**Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260810.1054...v0.0.33-nightly.20260810.1055

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260810.1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants