fix(web): update pills use readable theme foregrounds - #5938
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 13c0b81 Purely cosmetic styling changes that update CSS class names and color values to improve text readability in sidebar pills. No runtime behavior impact beyond visual appearance. You can customize Macroscope's approvability policy. Learn more. |
e13cf36 to
7fe63f1
Compare
7fe63f1 to
abce8da
Compare
Dismissing prior approval to re-evaluate abce8da
abce8da to
ff94f17
Compare
Dismissing prior approval to re-evaluate ff94f17
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ff94f17. Configure here.
ff94f17 to
13c0b81
Compare
## What's Changed * Move project settings to contextual project routes by @juliusmarminge in pingdotgg/t3code#5923 * Retain thread sidebar data when navigating to /settings so back navigation is instant by @juliusmarminge in pingdotgg/t3code#5930 * Automate production mobile EAS releases by @juliusmarminge in pingdotgg/t3code#5609 * Add settings and usage breadcrumbs by @juliusmarminge in pingdotgg/t3code#5929 * fix(web): correct model picker trigger padding by @Chrono-byte in pingdotgg/t3code#5935 * fix(web): show worktree icon in sidebar v2 by @tris203 in pingdotgg/t3code#5909 * fix(web): enable restore defaults after theme mix changes by @Lucenx9 in pingdotgg/t3code#5928 * fix(web): trait menu closes after you pick a level by @t3dotgg in pingdotgg/t3code#5879 * fix(web): align project name with headline by @carterwsmith in pingdotgg/t3code#5864 * fix(web): update pills use readable theme foregrounds by @chrisdeeming in pingdotgg/t3code#5938 ## New Contributors * @carterwsmith made their first contribution in pingdotgg/t3code#5864 **Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260810.1054...v0.0.33-nightly.20260810.1055 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260810.1055

What Changed
updateForegroundtoken for sidebar update-pill content.Why
Update pills used the stronger
updateaccent as text overupdateSurface, producing insufficient contrast across most built-in themes.Using the existing semantic foreground role fixes the named themes without changing their palettes. T3 Code Dark also needed a distinct
updateForeground, changed from#366ffbto#5c86ff.WCAG 2.2 AA requires at least 4.5:1 contrast for this 12px normal text. Before this change, the update label passed in only 1 of the 12 built-in theme/mode combinations; the other 11 ranged from 2.04:1 to 4.30:1. Using
updateForegroundraises every named theme to AA, while the dedicated T3 Code Dark adjustment raises its remaining failure from 3.88:1 to 5.08:1.UI Changes
Checklist
I included a video for animation/interaction changes— Not applicable; no motion or interaction changed.Note
Low Risk
Visual token and class changes only; no behavior, data, or security surface.
Overview
Fixes low-contrast text on sidebar update pills by using the semantic
updateForegroundrole instead of the strongupdateaccent for labels and icons.Desktop and provider update pills now apply
text-update-foreground(and the dismiss control matches). Dark default tokens remap--update-foregroundfrom primary blue tovar(--color-blue-400), and T3 Code Dark setsupdateForegroundto#51a2ffso small text onupdateSurfacemeets WCAG AA against the tinted pill background.Reviewed by Cursor Bugbot for commit 13c0b81. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix pill text colors to use readable
update-foregroundtheme tokensUpdates sidebar update pills to use the
text-update-foregroundcolor token instead oftext-updatefor text and icons. Also remaps--update-foregroundto--color-blue-400in index.css and updates the T3 Code dark theme palette in themePalette.ts to a lighter blue value.Macroscope summarized 13c0b81.