feat(adapters): run, ask on a terminal, and fill in a thin listing - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things a manager can need that it could not previously get.
Run is offered where a manager says both where a package went and where it links what it installs, which is what running one actually depends on. It also asks the package's own adapter for those paths rather than assuming everything lives where the built-in one puts things.
A terminal, for an operation that only works with one.
pacstall -Luhides the cursor and reads the terminal's settings even though it is only answering a question, and gives up without one. Ops declareneeds_terminaland run on a pty. Asking for a password on a terminal nobody can see would hang, so that combination is refused rather than left to wait.A thinner listing filled in, for a manager whose installed listing is only names. One run per package, only for the fields the listing left empty, and only when the manifest says the manager can be asked.
Stacked on #35.