feat(search): rank results by relevance, not by manager - #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results were concatenated in adapter order, so what you saw first depended on which manager was asked first rather than on what you typed.
They are now ranked: exact name, then prefix, then substring, then an abbreviation whose letters appear in order, and last anything matched on its description. Shorter names win within a tier.
The abbreviation scorer is deliberately not edit distance.
fdtofd-findis distance 5, worse than an unrelated short name, so Levenshtein would rank an obvious prefix match below noise.Stacked on #36.