fix(view): properly calculate offscreen state#2191
Closed
0xsven wants to merge 2 commits intopmndrs:masterfrom
Closed
fix(view): properly calculate offscreen state#21910xsven wants to merge 2 commits intopmndrs:masterfrom
0xsven wants to merge 2 commits intopmndrs:masterfrom
Conversation
|
@0xsven is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
Member
|
Duplicate of #1902 and implemented in v11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The View component is designed to work within a Canvas that is not necessarily fullscreen. According to the documentation:
Quote from the docs:
However, I observed that View wasn’t behaving as expected. Specifically, it was checking whether the View is offscreen, rather than checking if it's outside the canvas boundaries. This caused issues when View was partially or entirely within the canvas but still considered offscreen.
Here is a codesandbox: https://codesandbox.io/p/sandbox/view-skissor-forked-w2tds3?file=%2Fsrc%2Fstyles.css%3A38%2C1
Notice how the View (red border) is not always running when inside the canvas (blue border).
What
Maybe
isOffscreenshould even be renamed toisOffcanvas?Checklist