Change NoScope opacity for spectators and replays - #28485
Closed
timiimit wants to merge 5 commits into
Closed
Conversation
Member
|
Visual settings is the wrong place to do this (once you add more mod/replay-specific settings, it'll be a mess). There's already #19925 which spans on more than just one mod. Though, that PR just toggles mods on and off (or partially, see flashlight impl). Not sure how useful is opacity or any other future mod display setting during a replay, but if it's wanted, it may be a popover when you right-click(?) a mod in replay. Closing as incorrect direction. |
Member
|
Definitely should be part of the toggle support if at all. |
Contributor
Author
|
Toggling mods should be enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
NoScope mod was previously unwatchable in replays/spectator because cursor can be hidden for extended period of time which makes gameplay uninteresting.
Solution
This was addressed by making the smallest possible opacity in replays 50% by default. Additionally a SliderBar was added to Visual Settings in replays which can be used to control this value. SliderBar is visible only when watching a replay with NoScope mod.
Details