Fix docs npm install failure due to storybook peer dependency conflicts by Copilot · Pull Request #3008 · primer/css

Copilot · 2026-03-12T20:11:08Z

What are you trying to accomplish?

@geometricpanda/storybook-addon-badges@2.0.0 declares a peer dep on @storybook/blocks@^7.0.0, conflicting with @storybook/blocks@8.6.14 in the docs package. This causes cd docs && npm i to fail with ERESOLVE.

What approach did you choose and why?

docs/package.json: Bumped @geometricpanda/storybook-addon-badges from ^2.0.0 → ^2.0.5. Version 2.0.5 updated its peer dep to @storybook/blocks@^8.3.0, which is satisfied by the installed 8.6.14.
docs/.npmrc (new): Added legacy-peer-deps=true. The docs package intentionally runs a mixed Storybook 8/10 setup — @storybook/blocks@8.x is installed for npm resolution but aliased to @storybook/addon-docs/blocks at webpack time; @storybook/manager-api@8.x and @storybook/theming@8.x are shimmed to re-export from storybook v10. This causes unavoidable peer conflicts (@storybook/blocks@8.x declares storybook@^8.x as a peer, but storybook@10.x is installed). The root .npmrc already has legacy-peer-deps=true but it's not inherited when npm runs from a subdirectory with its own package.json.

What should reviewers focus on?

The mixed Storybook 8/10 setup is pre-existing and intentional (see docs/.storybook/main.js webpack alias and docs/scripts/fix-storybook-shims.mjs). The legacy-peer-deps addition just makes npm consistent with the root install behavior for this package.

Can these changes ship as is?

Yes, this PR does not depend on additional changes. 🚢

- Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0) - Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

changeset-bot · 2026-03-12T20:11:15Z

⚠️ No Changeset found

Latest commit: 24adc63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* Initial plan * Initial plan for fixing storybook build failures Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: update packages, add SCSS/Babel/docs support, fix compat shims Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Address code review: remove unused assert dep, rename config var, clean up shim script Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix docs npm install failure due to storybook peer dependency conflicts (#3008) * Initial plan * fix: resolve storybook peer dependency conflicts in docs install - Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0) - Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

* Initial plan * Fix ESM compatibility: replace require('sass') with ESM import in main.js Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: complete v7→v10 migration (#3007) * Initial plan * Initial plan for fixing storybook build failures Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: update packages, add SCSS/Babel/docs support, fix compat shims Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Address code review: remove unused assert dep, rename config var, clean up shim script Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix docs npm install failure due to storybook peer dependency conflicts (#3008) * Initial plan * fix: resolve storybook peer dependency conflicts in docs install - Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0) - Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

…ybook script (#3004) * Bump tar and storybook in /docs Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). These dependencies need to be updated together. Removes `tar` Updates `storybook` from 7.6.21 to 10.2.17 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.17/code/core) --- updated-dependencies: - dependency-name: tar dependency-version: dependency-type: indirect - dependency-name: storybook dependency-version: 10.2.17 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Initial plan * Fix storybook build: remove invalid positional argument `public/static` Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix ESM compatibility in .storybook/main.js (#3005) * Initial plan * Fix ESM compatibility: replace require('sass') with ESM import in main.js Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: complete v7→v10 migration (#3007) * Initial plan * Initial plan for fixing storybook build failures Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: update packages, add SCSS/Babel/docs support, fix compat shims Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Address code review: remove unused assert dep, rename config var, clean up shim script Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix docs npm install failure due to storybook peer dependency conflicts (#3008) * Initial plan * fix: resolve storybook peer dependency conflicts in docs install - Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0) - Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * fix: regenerate docs/package-lock.json to resolve storybook binary not found (#3009) * Initial plan * fix: regenerate docs/package-lock.json to fix storybook binary not found Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

Copilot AI and others added 2 commits March 12, 2026 20:04

Initial plan

909348d

Copilot AI assigned Copilot and llastflowers Mar 12, 2026

Copilot created this pull request from a session on behalf of llastflowers March 12, 2026 20:11 View session

Copilot AI temporarily deployed to github-pages March 12, 2026 20:12 Inactive

github-actions Bot temporarily deployed to Storybook Preview March 12, 2026 20:12 Inactive

llastflowers added the skip changeset label Mar 12, 2026

llastflowers marked this pull request as ready for review March 12, 2026 20:13

llastflowers requested review from a team as code owners March 12, 2026 20:13

llastflowers requested a review from TylerJDev March 12, 2026 20:13

llastflowers approved these changes Mar 12, 2026

View reviewed changes

llastflowers merged commit 9c62235 into copilot/fix-github-actions-workflow-one-more-time Mar 12, 2026
19 of 20 checks passed

llastflowers deleted the copilot/fix-github-actions-workflow-please-work branch March 12, 2026 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix docs npm install failure due to storybook peer dependency conflicts#3008

Fix docs npm install failure due to storybook peer dependency conflicts#3008
llastflowers merged 2 commits intocopilot/fix-github-actions-workflow-one-more-timefrom
copilot/fix-github-actions-workflow-please-work

Copilot AI commented Mar 12, 2026

Uh oh!

changeset-bot Bot commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Mar 12, 2026

What are you trying to accomplish?

What approach did you choose and why?

What should reviewers focus on?

Can these changes ship as is?

Uh oh!

changeset-bot Bot commented Mar 12, 2026

⚠️ No Changeset found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants