fix: regenerate docs/package-lock.json to resolve storybook binary not found#3009
Merged
llastflowers merged 2 commits intocopilot/fix-github-actions-workflow-another-onefrom Mar 12, 2026
Conversation
|
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [66861717721] Fix failing GitHub Actions workflow Deploy preview / Build
fix: regenerate docs/package-lock.json to resolve storybook binary not found
Mar 12, 2026
llastflowers
approved these changes
Mar 12, 2026
llastflowers
approved these changes
Mar 12, 2026
46f372f
into
copilot/fix-github-actions-workflow-another-one
17 of 18 checks passed
llastflowers
added a commit
that referenced
this pull request
Mar 12, 2026
…ybook script (#3004) * Bump tar and storybook in /docs Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). These dependencies need to be updated together. Removes `tar` Updates `storybook` from 7.6.21 to 10.2.17 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.17/code/core) --- updated-dependencies: - dependency-name: tar dependency-version: dependency-type: indirect - dependency-name: storybook dependency-version: 10.2.17 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Initial plan * Fix storybook build: remove invalid positional argument `public/static` Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix ESM compatibility in .storybook/main.js (#3005) * Initial plan * Fix ESM compatibility: replace require('sass') with ESM import in main.js Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: complete v7→v10 migration (#3007) * Initial plan * Initial plan for fixing storybook build failures Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix Storybook 10 build: update packages, add SCSS/Babel/docs support, fix compat shims Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Address code review: remove unused assert dep, rename config var, clean up shim script Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix docs npm install failure due to storybook peer dependency conflicts (#3008) * Initial plan * fix: resolve storybook peer dependency conflicts in docs install - Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0) - Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * fix: regenerate docs/package-lock.json to resolve storybook binary not found (#3009) * Initial plan * fix: regenerate docs/package-lock.json to fix storybook binary not found Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Deploy preview / Build" CI job was failing with
sh: 1: storybook: not found(exit code 127). Thestorybookbinary was never symlinked intodocs/node_modules/.bin/afternpm install.What are you trying to accomplish?
Fix the failing CI job caused by the
storybookCLI binary not being available afternpm installin thedocs/directory.What approach did you choose and why?
The committed
docs/package-lock.jsonlockedesbuildas a nested install undernode_modules/storybook/node_modules/esbuild(v0.27.3). This inconsistent resolution — caused by the mixed Storybook 8/10 peer dependency graph indocs/package.json— prevented npm from correctly symlinking thestorybookbinary.Regenerating the lock file (deleting it and re-running
npm install) resolvesesbuild@0.27.4at the top level, which allows npm to correctly linknode_modules/.bin/storybook.Key difference in the new lock file:
node_modules/storybook/node_modules/esbuild@0.27.3(nested, binary not linked)node_modules/esbuild@0.27.4(top-level, binary correctly linked)What should reviewers focus on?
The only change is
docs/package-lock.json. The large diff is expected for a lock file regeneration — package versions are broadly the same, just resolved differently. The Storybook 8/10 version mix indocs/package.json(which is the root cause of the fragile resolution) remains unchanged; fixing that is a separate concern.Can these changes ship as is?
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
storybook.js.org/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/css/css/docs/node_modules/.bin/storybook build -o public/storybook ms.mjs(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.