Josir Gomes Bio

[josircg]

Closes #1838

Checklist

• Assign yourself in the "Assignees" menu
• Assign at least one individual or team to "Reviewers"
• if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
• Add the appropriate "Label"
• Ensure the Travis CI checks pass
• Check the live preview of your PR on Netlify
• If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.

[rivaquiroga]

Hi @josircg! Welcome to the team. I added the Spanish translation of your Bio + the missing team roles.
Your affiliation is also missing. Let us know when you complete that, so we can add the translation.

[josircg]

Thank you @rivaquiroga . I will add the affiliation and photo on a second commit.
I was anxious to test if the pull request requirements are ok :)

I was in doubt if I have to have travis installed on my machine to send the pull request so I did a small change to test. I could not assign myself to the issue and I thought this could be a problem either.

[walshbr]

@josircg - Travis is a web service that doesn't need to be installed on your computer. And you should be able to assign yourself to a pull request, but ultimately that shouldn't cause any errors if some quirk of the interface won't let you do so. It's more about keeping things organized and tidy.

[rivaquiroga]

@josircg, maybe you can't assign yourself because you are not yet part of the team here in Github. Did you inform Zoe about your github username?

[josircg]

No. I imagined that it was informed already. But I did it now.

[DanielAlvesLABDH]

Josir already mentioned his username in this message (#1830 (comment)). Probably the problem was the opening of another issue.

[acrymble]

@josircg can you please use the checklist in the original comment above? This helps make sure you've done all the checks before someone reviews it. It's a series of reminders of how to do a proper pull request.

[josircg]

@josircg can you please use the checklist in the original comment above? This helps make sure you've done all the checks before someone reviews it. It's a series of reminders of how to do a proper pull request.

Hi. I don't have access yet to do any change on the original issues (#1830), or assign myself to them. I've already asked for help to @ZoeLeBlanc

[josircg]

Well... I just found the invitation on my spam box. And it's expired :/
@ZoeLeBlanc @rivaquiroga Could you send another invitation?

[josircg]

@rivaquiroga I think everything is ok now. Need only your final approval.

[rivaquiroga]

@josircg, the french translation is missing. You need to tag the french team + Marie Christine to ask for the translation.

[josircg]

@josircg, the french translation is missing. You need to tag the french team + Marie Christine to ask for the translation.

I asked someone else to translate but I'm tagging @mariechristineb to verify if it's ok.

[mariechristineb]

I didn't want to start a new branch so I added my changes to the translation in a comment

[acrymble]

Did you include your photo in the pull request @josircg ?

[josircg]

Did you include your photo in the pull request @josircg ?

No. I will do it in a second commit because I have to find/assemble a squared black/white photo and didn't want to late the onboarding process. Photo added now.

[rivaquiroga]

@josircg, it seems that the only thing missing is your affiliation.

[rivaquiroga]

Last thing and then we are ready to merge: the file name of your photo must be the same you use in ph_authors. If you want to appear as Josir Cardoso Gomes there, the file name should be josir-cardoso-gomes.png

[josircg]

Hi @rivaquiroga. Should I have to close the issue or is it closed only when deployed?

[JoshuaGOB]

Hi @josircg We're are just waiting for the review from @mariechristineb and then we can close the ticket. Is this correct @rivaquiroga ?