Skip to content

Conversation

@ZoeLeBlanc
Copy link
Member

add the reason for your pull request here

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

@ZoeLeBlanc ZoeLeBlanc self-assigned this Jul 23, 2022
@ZoeLeBlanc
Copy link
Member Author

Ok @anisa-hawes think I found a short term solution to our build issue. Essentially htmlproofer has updated to a new version and while I would like us to start using it, I couldn't get the newer version working. So for now, we are using an older version which required me forking a github action and deploying it to docker. So if we merge this in and pull down into the existing PRs we should be good to go.

If this all sounds good to you, I'll go ahead and merge this in. Thanks!

@anisa-hawes
Copy link
Contributor

Amazing, @ZoeLeBlanc! ✨ Thank you for your support with this. I'm happy for you to merge this in!

Next step will be for me to re-base the other PRs in our pipeline so we can move forwards.

@ZoeLeBlanc
Copy link
Member Author

Hey @anisa-hawes! Thanks so much for giving me the thumbs up. Would you mind actually approving the PR though since I need that to merge it in?

@anisa-hawes anisa-hawes self-requested a review July 25, 2022 16:39
Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ZoeLeBlanc!

@ZoeLeBlanc ZoeLeBlanc merged commit 6d76c86 into gh-pages Jul 25, 2022
@ZoeLeBlanc ZoeLeBlanc deleted the issue-2633 branch July 25, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants