Skip to content

Don't require user to provide libglm #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2020
Merged

Don't require user to provide libglm #387

merged 3 commits into from
Jul 27, 2020

Conversation

@revmischa
Copy link
Member

@revmischa revmischa commented Jul 26, 2020 •
edited
Loading

We already provide the glm headers in vendor/, they just need to be added to the autoconf include path so it can find them.

Should help with #381 glm errors (I assume)

@revmischa revmischa self-assigned this Jul 26, 2020
@revmischa
Copy link
Member Author

revmischa commented Jul 26, 2020

@milkdropper can remove glm from nuget and use the included headers

@revmischa revmischa mentioned this pull request Jul 26, 2020
Closed
@revmischa revmischa requested a review from milkdropper July 26, 2020 20:46
@revmischa revmischa merged commit e51b2c7 into master Jul 27, 2020
@kblaschke kblaschke deleted the glm-vendor branch June 23, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milkdropper milkdropper Awaiting requested review from milkdropper

Assignees

@revmischa revmischa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@revmischa @milkdropper