Replace Source with dedent where possible#3864
Merged
asottile merged 1 commit intopytest-dev:masterfrom Aug 23, 2018
asottile:source_to_dedent
Merged
Replace Source with dedent where possible#3864asottile merged 1 commit intopytest-dev:masterfrom asottile:source_to_dedent
asottile merged 1 commit intopytest-dev:masterfrom
asottile:source_to_dedent
Conversation
wimglenn
approved these changes
Aug 23, 2018
nicoddemus
approved these changes
Aug 23, 2018
Member
|
Cool @asottile! 👍 |
| assert f.statement == _pytest._code.Source("") | ||
| finally: | ||
| f.code.__class__.fullsource = prop | ||
| with mock.patch.object(f.code.__class__, "fullsource", None): |
Member
There was a problem hiding this comment.
this should use monkeypatch
Member
Author
There was a problem hiding this comment.
oops didn't see this until already merged -- monkeypatch has a much wider scope than the code I was replacing and so it is not equivalent.
(And since this is monkeypatching a pytest internal I don't really want that to leak out of this test)
Curious also why to prefer monkeypatch over mock.patch -- the latter is much more battle tested and has a well defined patch scope due to the with block
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also manually reindented a lot of tqs literals since
blackmunged themI only touched
./testingas to avoid changing public behaviour