Improvements to TIFF is_animated and n_frames#3714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__nextreveals if there is a next frame or not,_is_animatedcan be determined on the initial seek. That also means that the tests can be simplified slightly, becauseis_animatedno longer interacts with_n_frames. You might think that this means that theis_animateddecorator can be replaced with just a variable. However,MicImageFileinheritsTiffImageFile, andis_animatedcan't be set directly in that circumstance.__nextreveals if there is a next frame or not,_n_framescan be populated automatically if seeking to the last frame.n_framesfor the last frame can be made faster by starting from the last frame ever seeked, rather than just from the current position.