Skip to content

Add favicon to Read the Docs - #4375

Merged
hugovk merged 1 commit into
python-pillow:masterfrom
hugovk:add-docs-favicon
Jan 20, 2020
Merged

Add favicon to Read the Docs#4375
hugovk merged 1 commit into
python-pillow:masterfrom
hugovk:add-docs-favicon

Conversation

@hugovk

@hugovk hugovk commented Jan 20, 2020

Copy link
Copy Markdown
Member

@radarhere

Copy link
Copy Markdown
Member

The documentation says that the ico file should be 32 pixels at most, but copying what we're already doing on another site seems perfectly reasonable.

@hugovk

hugovk commented Jan 20, 2020

Copy link
Copy Markdown
Member Author

Yep, saw that, and seems to work. The ico file does also contains a 32x32:

$ identify docs/resources/favicon.ico
docs/resources/favicon.ico[0] PNG 256x256 256x256+0+0 8-bit sRGB 102602B 0.000u 0:00.009
docs/resources/favicon.ico[1] ICO 48x48 48x48+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[2] ICO 32x32 32x32+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[3] ICO 24x24 24x24+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[4] ICO 16x16 16x16+0+0 8-bit sRGB 102602B 0.000u 0:00.000

@hugovk
hugovk merged commit 455a113 into python-pillow:master Jan 20, 2020
@hugovk
hugovk deleted the add-docs-favicon branch January 20, 2020 21:52
@hugovk

hugovk commented Jan 20, 2020

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants