Add favicon to Read the Docs - #4375
Merged
Merged
Conversation
radarhere
approved these changes
Jan 20, 2020
Member
|
The documentation says that the ico file should be 32 pixels at most, but copying what we're already doing on another site seems perfectly reasonable. |
Member
Author
|
Yep, saw that, and seems to work. The ico file does also contains a 32x32: $ identify docs/resources/favicon.ico
docs/resources/favicon.ico[0] PNG 256x256 256x256+0+0 8-bit sRGB 102602B 0.000u 0:00.009
docs/resources/favicon.ico[1] ICO 48x48 48x48+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[2] ICO 32x32 32x32+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[3] ICO 24x24 24x24+0+0 8-bit sRGB 102602B 0.000u 0:00.000
docs/resources/favicon.ico[4] ICO 16x16 16x16+0+0 8-bit sRGB 102602B 0.000u 0:00.000 |
Member
Author
|
Now on https://pillow.readthedocs.io/en/latest/ And next release at https://pillow.readthedocs.io/en/stable/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-uses the favicon from https://github.com/python-pillow/python-pillow.github.io/blob/master/images/pillow.ico
Edit: on a Retina screen: