Fixed comparison warnings#4551
Merged
Merged
Conversation
radarhere
commented
Apr 13, 2020
| if (len) { | ||
| if (len > sizeof(params.tcp_rates) / sizeof(params.tcp_rates[0])) | ||
| if (len > 0) { | ||
| if ((unsigned)len > sizeof(params.tcp_rates) / sizeof(params.tcp_rates[0])) |
Member
Author
There was a problem hiding this comment.
len comes from PySequence_Length, which can return -1 on failure. So if we change the condition to not just exclude empty sequence lengths, but also sequence lengths with errors, then the unsigned cast becomes safe to use.
Closed
radarhere
force-pushed
the
warnings
branch
2 times, most recently
from
April 26, 2020 02:23
7e8c1c2 to
203f57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.