Replace spaces with tabs and add to pre-commit linting#4601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
PR #4600 replaced the tabs with spaces in the .c and .h files. 🎉 Let's keep them out with a lint checker.
Now, there are some test images (like .eps) that contain valid tabs and also makefiles must use tabs.
We've a couple of options:
This PR does the latter to keep the net wider. It's possible it could find a valid tab in another file in the future, and we could adjust the exclusion list then. Or, as the
exclude:is a regex, we could also exclude directories now.But the former could be okay too, most invalid tabs would probably show up in a smaller set of file types that account for the most files. I don't have a strong preference.