Skip to content

Remove redundant noqa#4673

Merged
radarhere merged 2 commits into
python-pillow:masterfrom
hugovk:yesqa
Jun 8, 2020
Merged

Remove redundant noqa#4673
radarhere merged 2 commits into
python-pillow:masterfrom
hugovk:yesqa

Conversation

@hugovk

@hugovk hugovk commented Jun 6, 2020

Copy link
Copy Markdown
Member

Changes proposed in this pull request:

  • Add https://github.com/asottile/yesqa to pre-commit to remove redundant noqa markers
  • Run pre-commit hooks which can edit code first, they may fix things later hooks would fail on
  • pre-commit autoupdate: only updated pre-commit/pre-commit-hooks

@radarhere

Copy link
Copy Markdown
Member

yesqa doesn't support Python 3.5 - https://github.com/asottile/yesqa/blob/master/setup.cfg. Is it worth waiting until Pillow 7.3 to include this?

@hugovk

hugovk commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

I don't think we need to wait, this is only a dev thing.

yesqa is run by the CI lint job (has a newer supported Python version), and by anyone who is developing locally and has installed pre-commit for this repo, which I guess is a small set of people.

If it's a problem for anyone, we can remove it or adjust it somehow.

@radarhere
radarhere merged commit ebd6901 into python-pillow:master Jun 8, 2020
@hugovk
hugovk deleted the yesqa branch June 8, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants