Improved formatting#4682
Merged
Merged
Conversation
hugovk
approved these changes
Jun 11, 2020
|
|
||
| :param xdisplay: X11 Display address. Pass ``None`` to grab the default system screen. | ||
| Pass ``""`` to grab the default X11 screen on Windows or macOS. | ||
| :param xdisplay: X11 Display address. Pass ``None`` to grab the default system screen. Pass ``""`` to grab the default X11 screen on Windows or macOS. |
Member
There was a problem hiding this comment.
👍
I don't quite understand the logic of why it was doing the odd formatting before and why this fixes it. Do you?
| @@ -192,9 +192,9 @@ class ImageCmsTransform(Image.ImagePointHandler): | |||
|
|
|||
Member
There was a problem hiding this comment.
In this file, should we also give code formatting/linking to:
ImageCms.buildTransform()orImageCms.buildTransformFromOpenProfiles())- If you want to modify
imin-place - ImageCms.INTENT_PERCEPTUAL = 0 (DEFAULT)
ImageCms.INTENT_RELATIVE_COLORIMETRIC = 1
ImageCms.INTENT_SATURATION = 2
ImageCms.INTENT_ABSOLUTE_COLORIMETRIC = 3 - CmsProfile
Should PyCMSError be code formatted rather than bold?
https://pillow--4682.org.readthedocs.build/en/4682/reference/ImageCms.html
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes should be obvious from the diff, except for the ImageGrab change, which fixes the formatting from this screenshot.