Call _accept instead of duplicating code#4720
Merged
Merged
Conversation
hugovk
reviewed
Jun 23, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_opensometimes contains the same check as_accept. This PR changes some plugins to call_acceptdirectly, instead of just duplicating the code.This is already done by some other plugins. For example,
Pillow/src/PIL/CurImagePlugin.py
Lines 38 to 45 in 2456601