Add Circuit.zip method #3075
Merged
Add Circuit.zip method #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
approved these changes
Jun 7, 2020
Collaborator
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
Just one small comment then LGTM.
| assert cirq.Circuit().zip(cirq.Circuit(cirq.Moment())) == cirq.Circuit( | ||
| cirq.Moment()) | ||
|
|
||
| assert circuit1.zip(circuit2) == circuit2.zip(circuit1) == cirq.Circuit( |
Collaborator
There was a problem hiding this comment.
Do you want to have a line comment above this and below here, since there is a heading above for empty cases, but it is not visually clear where the section of "Empty cases" ends.
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
dabacon
reviewed
Jun 8, 2020
| >>> circuit1 = cirq.Circuit(cirq.H(a), cirq.CNOT(a, b)) | ||
| >>> circuit2 = cirq.Circuit(cirq.X(c), cirq.Y(c), cirq.Z(c)) | ||
| >>> circuit3 = cirq.Circuit(cirq.Moment(), cirq.Moment(cirq.S(d))) | ||
| >>> print(circuit1.zip(circuit2)) |
Collaborator
There was a problem hiding this comment.
Having this as an instance method feels strange because this isn't how it is done in python?
Collaborator
There was a problem hiding this comment.
It's a bit unusual but makes sense to me. Because of how Python binds methods, both Circuit.merge(c1, c2) and c1.merge(c2) will work.
Collaborator
There was a problem hiding this comment.
I just start getting scared when we hit line 1269 in a single class definition :)
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
Handy to have around when building circuits up in tiled pieces and wanting to guarantee the moment structure comes out right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handy to have around when building circuits up in tiled pieces and wanting to guarantee the moment structure comes out right.