Change Operation.with_qubits return type to match self type #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
approved these changes
Jun 25, 2020
| def with_qubits(self, *new_qubits: 'cirq.Qid') -> 'cirq.Operation': | ||
| return self.gate.on(*new_qubits) | ||
| def with_qubits(self: TSelf, *new_qubits: 'cirq.Qid') -> TSelf: | ||
| return cast(TSelf, self.gate.on(*new_qubits)) |
Collaborator
There was a problem hiding this comment.
Optional: Have you tried making GateOperation parametrized with the type of gate it wraps? I think this should let us remove the cast.
Contributor
Author
There was a problem hiding this comment.
I didn't try that, but my experience with "genericizing" classes in python is that it is not trivial, especially for something this widely used. The relationship between gates and operations is also complicated by various specialized operation subclasses that we have.
tai271828
pushed a commit
to tai271828/Cirq
that referenced
this pull request
Jun 26, 2020
tai271828
pushed a commit
to tai271828/Cirq
that referenced
this pull request
Jun 27, 2020
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the return type of
transform_qubitsin the same way. AFAICT this should always be correct, but it's sometimes tricky to convince mypy of this (have to cast inGateOperation.with_qubits, for example).